<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4910" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>cool :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4910#inline-20053" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalconfigpage.cpp:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="n">GlobalConfigPage</span><span style="color: #aa2211">::~</span><span class="n">GlobalConfigPage</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">= default</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4910#inline-20051" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalsettings.kcfg:10</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <entry name="heaptrackExecutable" key="heaptrackExecutable" type="Path">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <default>/usr/bin/heaptrack</default>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> </entry>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it should default to <tt style="background: #ebebeb; font-size: 13px;">heaptrack</tt> and be found in the PATH via QStandardPaths</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4910#inline-20052" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">globalsettings.kcfg:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <entry name="heaptrackGuiExecutable" key="heaptrackGuiExecutable" type="Path">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <default>/usr/bin/heaptrack_gui</default>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> </entry>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">dito</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4910#inline-20050" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">job.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">static</span> <span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> <span class="n">resultRegex</span> <span style="color: #aa2211">=</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QRegularExpression</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"heaptrack output will be written to </span><span style="color: #bb6622">\\\"</span><span style="color: #766510">(.+)</span><span style="color: #bb6622">\\\"</span><span style="color: #766510">"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">instead of parsing it, we could add a patch to heaptrack to specify a path yourself, i.e. something like <tt style="background: #ebebeb; font-size: 13px;">-o</tt>, and then you could use that here</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4910" rel="noreferrer">https://phabricator.kde.org/D4910</a></div></div><br /><div><strong>To: </strong>antonanikin, mwolff<br /><strong>Cc: </strong>kdevelop-devel<br /></div>