<table><tr><td style="">mwolff requested changes to this revision.<br />mwolff added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4816" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4816#inline-20049" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemmodel.cpp:139</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span class="n">tooltip</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">" (%1)"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">prettyPath<span class="bright">Name</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_path</span></span><span class="bright"></span><span class="p"><span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">tooltip</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">" (%1)"</span><span class="p">).</span><span class="n">arg</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>prettyPath</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">setPlaceHolderText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Analysis of (%1) started, expect problems to come..."</span><span class="p">,</span> <span class="n">m_prettyPath</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QString</span><span class="p">(),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">as said in the other review: the placeholder should be set once, and then get displayed whenever the model is empty.</p>
<p style="padding: 0; margin: 8px;">also reword the message to make it less funny, and remove the parens:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Analysis of %1 started...</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4816#inline-20047" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemmodel.cpp:140</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">setPlaceHolderText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Analysis of (%1) started, expect problems to come..."</span><span class="p">,</span> <span class="n">m_prettyPath</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QString</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">projectLocation</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">both times passing <tt style="background: #ebebeb; font-size: 13px;">QString()</tt>, as I said in the other report - this argument should be removed</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4816#inline-20048" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemmodel.cpp:141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">QString</span><span class="p">(),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">projectLocation</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I also don't get why we want to pass the location</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4816" rel="noreferrer">https://phabricator.kde.org/D4816</a></div></div><br /><div><strong>To: </strong>antonanikin, kfunk, KDevelop, mwolff<br /><strong>Cc: </strong>mwolff, kfunk, kdevelop-devel<br /></div>