<table><tr><td style="">kossebau created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4815" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Having an explicit button to Cancel instead of just the option to close<br />
the window follows other dialogs.<br />
Labelling the accepting button with "Attach" instead of "Ok" makes it<br />
more obvious what happens on a click, as akso recommended by<br />
<a href="https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R32 KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>buttonsForAttachProcessDialog</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4815" rel="noreferrer">https://phabricator.kde.org/D4815</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>debuggers/common/dialogs/processselection.cpp<br />
debuggers/common/dialogs/processselection.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>