<table><tr><td style="">flherne updated this revision to Diff 11846.<br />flherne edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-xpgb3p7znipgra6/" rel="noreferrer">(Show Details)</a><br />flherne edited the test plan for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-tytyf65o7jdcomq/" rel="noreferrer">(Show Details)</a><br />flherne added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4182" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Added an 'isProperty' flag to FunctionDeclaration to avoid regressing for the moment. (in fact it should be slightly better, because it understands <tt style="background: #ebebeb; font-size: 13px;">@foo.getter</tt>).</p>
<p>Left Python::ClassDeclaration in as a stub - without the decorator decls, it now doesn't have anything, but as you say it would make sense to store strings or something similar for use in the tooltips.</p></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>Also fixes a bug - decorator declarations were never *removed* from a function, so removing a decorator would have no effect until renaming or moving the function.<br />
<br />
<span style="padding: 0 2px; color: #333333; background: #f8cbcb;">Regression - codecompletion now adds brackets to property accesses.<br />
Could add a temporary 'isProperty' status to functions, but I hope to implement real property support soonish</span><span style="padding: 0 2px; color: #333333; background: #a6f3a6;">The new isProperty() thing should be replaced by real property types/declarations at some point</span>.</div></div></div><br /><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>Removes the decorator duchaintests, because they don't make sense without decorator declarations. The visible behaviour we actually implement (static/classmethods) is already included in several other tests.<br />
<br />
<span style="padding: 0 2px; color: #333333; background: #f8cbcb;">Adds XFAIL to one completion test.<br />
<br />
No other</span><span style="padding: 0 2px; color: #333333; background: #a6f3a6;">No known</span> regressions.</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D4182?vs=10310&id=11846" rel="noreferrer">https://phabricator.kde.org/D4182?vs=10310&id=11846</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4182" rel="noreferrer">https://phabricator.kde.org/D4182</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>codecompletion/items/functiondeclaration.cpp<br />
duchain/declarationbuilder.cpp<br />
duchain/declarationbuilder.h<br />
duchain/declarations/classdeclaration.cpp<br />
duchain/declarations/classdeclaration.h<br />
duchain/declarations/decorator.h<br />
duchain/declarations/functiondeclaration.cpp<br />
duchain/declarations/functiondeclaration.h<br />
duchain/expressionvisitor.cpp<br />
duchain/helpers.h<br />
duchain/tests/pyduchaintest.cpp<br />
duchain/tests/pyduchaintest.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>flherne, brauch<br /><strong>Cc: </strong>kdevelop-devel<br /></div>