<table><tr><td style="">rjvbb added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4411" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4411#82688" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D4411#82688</a>, <a href="https://phabricator.kde.org/p/mwolff/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@mwolff</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>sorry, but nested eventloops are a no-go.</p>
<p>the api has to be restructured to allow async assistants. until that is not done, shoehorning it in this way is a clear -2 from my side</p></div>
</blockquote>
<p>Is it worth anyone's time then that I try to deal with the other comments?<br />
Given the way the API is implemented in multiple places over 2 projects and the amount of work it will thus be to rewrite it I'm going to leave that to someone who knows the code much better. Or maybe it's a nice GSOC project (deadline for proposals coming up).<br />
Just be aware that the UI freezes are a real blocker; having to wait 2-3s (or more) *each* time you stumble upon an unknown variable is just not acceptable and can put people off very quickly.</p>
<p>This was intended as an acceptable/reasonable workaround, which is also why I have changed as little as possible to the actual payload code.<br />
I just have 1 request: If this won't go in please don't break the patch (too much) before a real fix is committed, so this workaround remains available as an optional local patch for those who want to use it.</p>
<p>Quick reactions to the comments:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">the <tt style="background: #ebebeb; font-size: 13px;">interrupted</tt> global var. is scheduled to go into the <tt style="background: #ebebeb; font-size: 13px;">UDPWorkerThread</tt> class, hasn't been done yet because:</li>
<li class="remarkup-list-item">the #if 0 blocks are still there to make it easier to compare behaviour under old and new implementations.</li>
<li class="remarkup-list-item">UDP = Unknown Declaration Problem, no confusion intended (or expected...) with the networking protocol.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R782 KDevelop Clang Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4411" rel="noreferrer">https://phabricator.kde.org/D4411</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rjvbb, KDevelop, mwolff<br /><strong>Cc: </strong>mwolff, kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>