<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4232" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good from a first very quick look at Okteta related things. More later.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4232#inline-16760" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">memviewdlg.cpp:153</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="bright">    </span><span class="n"><span class="bright">bytesEdit</span></span><span style="color: #aa2211">-></span><span class="n">set<span class="bright">ReadOnly</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #304a96"><span class="bright">false</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="bright">    </span><span class="n"><span class="bright">bytesEdit</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setOverwriteMode</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #304a96"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">bytesEdit</span><span style="color: #aa2211">-></span><span class="n">setOverwriteOnly</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">bytesEdit</span><span style="color: #aa2211">-></span><span class="n">setAutoDelete</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="bright"></span><span class="n"><span class="bright">m_memViewView</span></span><span style="color: #aa2211">-></span><span class="n">set<span class="bright">GroupSpacingWidth</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">12</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="bright"></span><span style="color: #74777d"><span class="bright">//m_memViewView->setResizeStyle(); - Currently not able to see which function I need to call here</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">KHE</span><span style="color: #aa2211">::</span><span class="n">ValueColumnInterface</span> <span style="color: #aa2211">*</span><span class="n">valueColumn</span> <span style="color: #aa2211">=</span> <span class="n">KHE</span><span style="color: #aa2211">::</span><span class="n">valueColumnInterface</span><span class="p">(</span><span class="n">khexedit2_widget</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">valueColumn</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">valueColumn</span><span style="color: #aa2211">-></span><span class="n">setCoding</span><span class="p">(</span><span class="n">KHE</span><span style="color: #aa2211">::</span><span class="n">ValueColumnInterface</span><span style="color: #aa2211">::</span><span class="n">HexadecimalCoding</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">valueColumn</span><span style="color: #aa2211">-></span><span class="n">setNoOfGroupedBytes</span><span class="p">(</span><span style="color: #601200">4</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">valueColumn</span><span style="color: #aa2211">-></span><span class="n">setByteSpacingWidth</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">valueColumn</span><span style="color: #aa2211">-></span><span class="n">setGroupSpacingWidth</span><span class="p">(</span><span style="color: #601200">12</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">valueColumn</span><span style="color: #aa2211">-></span><span class="n">setResizeStyle</span><span class="p">(</span><span class="n">KHE</span><span style="color: #aa2211">::</span><span class="n">ValueColumnInterface</span><span style="color: #aa2211">::</span><span class="n">LockGrouping</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Method is called <tt style="background: #ebebeb; font-size: 13px;">setLayoutStyle</tt>here and defined on AbstractByteArrayView:<br />
<a href="https://api.kde.org/4.x-api/kdesdk-apidocs/okteta/html/classOkteta_1_1AbstractByteArrayView.html#a3f144ff69f257c7e90093b46357ebf62" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/4.x-api/kdesdk-apidocs/okteta/html/classOkteta_1_1AbstractByteArrayView.html#a3f144ff69f257c7e90093b46357ebf62</a></p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4232" rel="noreferrer">https://phabricator.kde.org/D4232</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>volden, KDevelop<br /><strong>Cc: </strong>kossebau, kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>