<table><tr><td style="">antonanikin requested changes to this revision.<br />antonanikin added a reviewer: antonanikin.<br />antonanikin added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4123" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>This works, thanks.</p>
<p>But I think you should add some comments to code about current restrictions - for example, tooltips are not updated after shortcut changing - we need to restart kdevelop for this.</p>
<p>And also maybe it better to use monospace font for shortcut displaying? Something like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">foreach(QAction *action, actionCollection()->actions()) {
QString shortCut;
if (!action->shortcut().isEmpty())
shortCut = action->shortcut().toString();
else if (!actionCollection()->defaultShortcut(action).isEmpty())
shortCut = actionCollection()->defaultShortcut(action).toString();
if (!shortCut.isEmpty())
action->setToolTip(QString("<html>%1 (<b><tt>%2</tt></b>)</html>").arg(action->toolTip()).arg(shortCut));
}</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4123" rel="noreferrer">https://phabricator.kde.org/D4123</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>tcanabrava, kfunk, apol, antonanikin<br /><strong>Cc: </strong>antonanikin, kdevelop-devel<br /></div>