<table><tr><td style="">kfunk updated this revision to Diff 9734.<br />kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3673" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Changes:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Make sure we pass the correct QModelIndexes to the model</li>
<li class="remarkup-list-item">Make it possible to enable/disable sorting from the outside</li>
<li class="remarkup-list-item">Only enable sorting for the outline<ul class="remarkup-list">
<li class="remarkup-list-item">Use QSFPM for Outline, QIdentityProxyModel for the rest</li>
</ul></li>
</ul>

<p>Unfortunately a lot of awful code, but that's what you get when the underlying model is already not well separated from the view...</p>

<p>Tested both outline + quick open extensively, seems to work</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3673?vs=9728&id=9734" rel="noreferrer">https://phabricator.kde.org/D3673?vs=9728&id=9734</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3673" rel="noreferrer">https://phabricator.kde.org/D3673</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/quickopen/expandingtree/expandingdelegate.cpp<br />
plugins/quickopen/expandingtree/expandingtree.cpp<br />
plugins/quickopen/expandingtree/expandingwidgetmodel.cpp<br />
plugins/quickopen/expandingtree/expandingwidgetmodel.h<br />
plugins/quickopen/quickopenmodel.cpp<br />
plugins/quickopen/quickopenplugin.cpp<br />
plugins/quickopen/quickopenwidget.cpp<br />
plugins/quickopen/quickopenwidget.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, brauch, KDevelop, nellex<br /><strong>Cc: </strong>kdevelop-devel, brauch, KDevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger<br /></div>