<table><tr><td style="">flherne updated this revision to Diff 9242.<br />flherne added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3770" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Oops, missed a couple of tests.</p>

<p>In the original patch, I have no idea what <tt style="background: #ebebeb; font-size: 13px;">setInSymbolTable()</tt> actually *does*, it's cargo-culted straight from <tt style="background: #ebebeb; font-size: 13px;">visitFunctionDefinition()</tt>. Please advise me if this is a bad idea. :P</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3770?vs=9241&id=9242" rel="noreferrer">https://phabricator.kde.org/D3770?vs=9241&id=9242</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3770" rel="noreferrer">https://phabricator.kde.org/D3770</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>duchain/declarationbuilder.cpp<br />
duchain/expressionvisitor.cpp<br />
duchain/expressionvisitor.h<br />
duchain/tests/pyduchaintest.cpp<br />
parser/ast.cpp<br />
parser/ast.h<br />
parser/astbuilder.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>flherne, brauch<br /><strong>Cc: </strong>kdevelop-devel<br /></div>