<table><tr><td style="">kfunk requested changes to this revision.<br />kfunk added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3597" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3597#inline-14190" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">codecompletionitemgrouper.cpp:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">///@todo make configurable. These are the attributes that can be respected for grouping.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">SimplifiedAttributesExtractor</span><span style="color: #aa2211">::</span><span class="n">groupingProperties</span> <span style="color: #aa2211">=</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Public</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Protected</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Private</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Static</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">TypeAlias</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Variable</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Class</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">GlobalScope</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">LocalScope</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">GlobalScope</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">|</span></span><span class="bright"> </span><span class="n"><span class="bright">CodeCompletionModel</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">NamespaceScope</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">SimplifiedAttributesExtractor</span><span style="color: #aa2211">::</span><span class="n">groupingProperties</span> <span style="color: #aa2211">=</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Public</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Protected</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Private</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Static</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">TypeAlias</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Variable</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">Class</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">GlobalScope</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">LocalScope</span> <span style="color: #aa2211">|</span> <span class="n">CodeCompletionModel</span><span style="color: #aa2211">::</span><span class="n">NamespaceScope</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Style: While at it: Let's do one enum value per line?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3597#inline-14189" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ematirov</span> wrote in <span style="color: #4b4d51; font-weight: bold;">mainwindow_p.cpp:321</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><ol class="remarkup-list">
<li class="remarkup-list-item">There is no need in moving this line</li>
<li class="remarkup-list-item">"action = " part can be omitted since it's not used anyway.</li>
</ol>
<p style="padding: 0; margin: 8px;">But maybe it's better to keep it as it is since it doesn't hurt and do not create not very needed change in history. <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a>?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please a) don't move the line, b) just omit <tt style="background: #ebebeb; font-size: 13px;">action =</tt>. That's fine.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3597#inline-14188" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ematirov</span> wrote in <span style="color: #4b4d51; font-weight: bold;">test_path.cpp:373</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Probably, this warning was false-positive warning since this one tests if equality overload is really working at all</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">+1, don't remove these lines</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/ematirov/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@ematirov</a> Is there a way to instruct PVS to ignore certain lines?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3597#inline-14191" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ematirov</span> wrote in <span style="color: #4b4d51; font-weight: bold;">vcspluginhelper.cpp:427</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Not really necessary probably. <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a>, same question?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Change looks good to me. I'd keep it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3597" rel="noreferrer">https://phabricator.kde.org/D3597</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>Sergobot, ematirov, kfunk<br /><strong>Cc: </strong>ematirov, kfunk, kdevelop-devel<br /></div>