<table><tr><td style="">ematirov added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3580" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3580#inline-14099" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">documentclassesfolder.cpp:233</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Don't insert unknown or forward declarations into the class browser</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">item</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">kind</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span class="n">CodeModelItem</span><span style="color: #aa2211">::</span><span class="n">Unknown<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span style="color: #aa2211">||</span> <span class="p">(</span><span class="n">item</span><span class="p">.</span><span class="n">kind</span> <span style="color: #aa2211">&</span> <span class="n">CodeModelItem</span><span style="color: #aa2211">::</span><span class="n">ForwardDeclaration</span><span class="p">)</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">CodeModelItem</span><span style="color: #aa2211">::</span><span class="n">Unknown</span> <span style="color: #aa2211">||</span> <span class="p">(</span><span class="n">item</span><span class="p">.</span><span class="n">kind</span> <span style="color: #aa2211">&</span> <span class="n">CodeModelItem</span><span style="color: #aa2211">::</span><span class="n">ForwardDeclaration</span><span class="p">)</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">continue</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Testing for CodeModelItem::Unknown makes no sense there since it's constant (0).<br />
The problem of original check is that (item.kind & 0) == 0 with any value of item.kind, so it doesn't check anything.</p>
<p style="padding: 0; margin: 8px;">Probably solutions are:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">check if item.kind is equal to CodeModelItem::Unknown instead of using bitwise operation there;</li>
<li class="remarkup-list-item">change value of CodeModelItem::Unknown to some power of 2 which is not used yet in CodeModelItem::Kind values.</li>
</ol>
<p style="padding: 0; margin: 8px;">Probably first one will go but I'll prefer to hear <a href="https://phabricator.kde.org/p/kfunk/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@kfunk</a>'s opinion on that</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R33 KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3580" rel="noreferrer">https://phabricator.kde.org/D3580</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>spencerb, KDevelop, kfunk, ematirov<br /><strong>Cc: </strong>kdevelop-devel<br /></div>