<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129416/">https://git.reviewboard.kde.org/r/129416/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2016, 6 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This revision moves the extra arguments history functionality from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeBuildDirChooser</code> to a simple separate class, and reuses that class in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakePreferences</code> so that the argument history is available in both dialogs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is something wonky with the extra arguments widget width for which I've only found a workaround I don't really understand. The widget hlayout is set to expanding in the ui.rc, but this causes the whole <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakePreferences</code> dialog to expand to accomodate the longest string in the argument history. I think that's because the dialog itself is configured to allow expansion whereas the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeBuildDirChooser</code> dialog has a fixed size. I presume that doing a dynamic_cast from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KComboBox</code> to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QComboBox</code> has a side-effect which causes the widget to adopt the desired width and not become a lot wider.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would of course love to be pointed to a proper way to do this!</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch introduces something I've been missing since I started using KDevelop: the possibility to reconfigure the way CMake is called after creating a project (= through the IDE rather than by editing a file in the .kdev4 directory).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch introduces the equivalent of all fields available on the fields available on the cmake initial creation dialog, under the advanced button.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's open for discussion whether the ExtraArguments field should have a history too (otherwise it could be a simple text entry box), and whether that history should be shared with the one from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeBuildDirChooser</code>.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd also like to point out that with this extended interface we could provide a reset button which removes <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeCache.txt</code> and the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeFiles</code> directory (or, more surgically, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMakeFiles/3.*</code>); this is actually required for changes to certain changes like the compiler to be used.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works as expected on OS X with Qt 5.6.2 and KF5 5.27.0</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/CMakeLists.txt <span style="color: grey">(5097f35)</span></li>
<li>projectmanagers/cmake/cmakebuilddirchooser.h <span style="color: grey">(186cc24)</span></li>
<li>projectmanagers/cmake/cmakebuilddirchooser.cpp <span style="color: grey">(2376bd3)</span></li>
<li>projectmanagers/cmake/cmakeextraargumentshistory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/cmakeextraargumentshistory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>projectmanagers/cmake/settings/cmakebuildsettings.ui <span style="color: grey">(96362dd)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.h <span style="color: grey">(d653927)</span></li>
<li>projectmanagers/cmake/settings/cmakepreferences.cpp <span style="color: grey">(e7cfbbb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129416/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>