<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3291" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Rest LGTM, nice idea! Please update the patch, then I'll have another look.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3291#inline-13345" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemnavigationcontext.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">a</span><span style="color: #aa2211">-></span><span class="n">severity</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">b</span><span style="color: #aa2211">-></span><span class="n">severity</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">      <span style="color: #aa4000">return</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">When sorting by multiple sort criterias I favor this pattern here: <a href="http://stackoverflow.com/a/3574724" class="remarkup-link" target="_blank" rel="noreferrer">http://stackoverflow.com/a/3574724</a></p>

<p style="padding: 0; margin: 8px;">Or, let's be fancy and use C++11 <tt style="background: #ebebeb; font-size: 13px;">std::tie</tt>: <a href="http://stackoverflow.com/a/17080762" class="remarkup-link" target="_blank" rel="noreferrer">http://stackoverflow.com/a/17080762</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3291#inline-13347" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemnavigationcontext.cpp:115</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #74777d">/// therefore we should make check for this case.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="n">QString</span> <span class="n">ProblemNavigationContext</span><span style="color: #aa2211">::</span><span class="n">html</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">text</span><span class="p">)</span> <span style="color: #aa4000">const</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Shouldn't this method be called <tt style="background: #ebebeb; font-size: 13px;">escapedHtml</tt> or something?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3291#inline-13346" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">problemnavigationcontext.cpp:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">  <span style="color: #aa4000">auto</span> <span class="n">action</span> <span style="color: #aa2211">=</span> <span class="n">assistant<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">a</span>ctions<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">value</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">index<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  <span style="color: #aa4000">auto</span> <span class="n">action</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">m_</span>assistant<span class="bright">sA</span>ctions<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="n">index<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">]</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">action</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">.at(...)</tt></p>

<p style="padding: 0; margin: 8px;">And you should assert that <tt style="background: #ebebeb; font-size: 13px;">action != nullptr</tt> in that case then. No need for the else-branch.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3291" rel="noreferrer">https://phabricator.kde.org/D3291</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antonanikin, KDevelop, kfunk<br /><strong>Cc: </strong>kdevelop-devel<br /></div>