<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129317/">https://git.reviewboard.kde.org/r/129317/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129317/diff/1/?file=483920#file483920line265" style="color: black; font-weight: bold; text-decoration: underline;">firsttimewizard.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">265</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="p">(</span><span class="k">new</span> <span class="n">QDir</span><span class="p">(</span><span class="n">destinationPath</span><span class="p">))</span><span class="o">-></span><span class="n">rename</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"arduino-"</span><span class="p">)</span> <span class="o">+</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="n">ARDUINO_SDK_VERSION_NAME</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"arduino"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">new</code> will be leaking. Just use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QDir(destinationPath).rename(...</code>.</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On November 3rd, 2016, 9:42 a.m. CET, Alexander Zhigalin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Zhigalin.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2016, 9:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-embedded
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The problem:
During the automatic SDK installation it was saved to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStandardPaths::writableLocation(QStandardPaths::DataLocation)</code>, usually inside <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">~/.local/share/kdevelop/</em>, inside a folder called <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">arduino-</em><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ARDUINO_SDK_VERSION_NAME</code> (which is a constraint).
The problem begins once the plugin get an update and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ARDUINO_SDK_VERSION_NAME</code> changes (which was already happened, <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">1.6.9</strong> to <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">1.6.10</strong>).
As we are searching for arduino inside <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">arduino-</em><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ARDUINO_SDK_VERSION_NAME</code>, the previously downloaded SDK will not be visible anymore.
With this path, SDK will be saved to <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStandardPaths::writableLocation(QStandardPaths::DataLocation)</code><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">/arduino</em> so it won't get lost anymore.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Please note, this change does not affect the internal SDK versioning, which is handled in an another place and based on </em>arduino/revisions.txt<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> content, not on the folder name</em></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>firsttimewizard.cpp <span style="color: grey">(4a915bf5b7e347bd7e15c94ff44c5361d61a5e4a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129317/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>