<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128530/">https://git.reviewboard.kde.org/r/128530/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 26th, 2016, 5:24 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128530/diff/1/?file=472453#file472453line88" style="color: black; font-weight: bold; text-decoration: underline;">shell/sessioncontroller.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">TryLockSessionResult</span> <span class="nf">tryLockSession</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">id</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">TryLockSessionResult</span> <span class="nf">tryLockSession</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span><span class="o">&</span> <span class="n">id</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">doLocking</span></span><span class="o"><span class="hl">=</span></span><span class="nb"><span class="hl">true</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why have this parameter if the function is not called anywhere like that?</p></pre>
</blockquote>
<p>On July 26th, 2016, 5:43 p.m. ART, <b>Alexander Zhigalin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because this function is an alias of the session locker function from shell/sessionlock.h which have this parameter</p></pre>
</blockquote>
<p>On July 26th, 2016, 5:51 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah but apparently nobody uses it, right?
Don't care though, if you see a reason to have it, it doesn't matter to me.</p></pre>
</blockquote>
<p>On November 2nd, 2016, 7:30 p.m. ART, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This broke binary compatibility!</p></pre>
</blockquote>
<p>On November 2nd, 2016, 7:44 p.m. ART, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's why this kind of patch never should go into stable branches.</p></pre>
</blockquote>
<p>On November 2nd, 2016, 8:11 p.m. ART, <b>Alexander Zhigalin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What is happened?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This change replaced tryLockSession(const QString&) with tryLockSession(const QString&, bool). It was committed to the 5.0 branch (which is supposed to stay binary-compatible), and we didn't notice until now. KDevelop 5.0.1 (or newer) won't start with KDevPlatformShell 5.0.0 (or older) and viceversa because of this changed symbol.</p></pre>
<br />
<p>- Nicolás</p>
<br />
<p>On August 25th, 2016, 7:22 p.m. ART, Alexander Zhigalin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Alexander Zhigalin.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2016, 7:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Improved documentation by fixing all the -Wdocumentation warnings which could be fixed ATM (almost all).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/ibuddydocumentfinder.h <span style="color: grey">(59ef367fbbf78693b211b8ecc66d9a9d9bbf5ba4)</span></li>
<li>interfaces/idocumentcontroller.h <span style="color: grey">(a66fe9c91b95590a7996eb365bfe1589c24b320f)</span></li>
<li>interfaces/iplugin.h <span style="color: grey">(1e09f12c795b8944cfe063c261e8b5cf198d772f)</span></li>
<li>interfaces/iproblem.h <span style="color: grey">(a3f2b93f270c4dec76a1f1d9a319bba42f7935ba)</span></li>
<li>interfaces/iuicontroller.h <span style="color: grey">(fe7d07ff0377361b1e950cc50ab0c65f2711566c)</span></li>
<li>interfaces/launchconfigurationpage.h <span style="color: grey">(73b810695161faf61cccbb5cc9270f135c43457a)</span></li>
<li>interfaces/launchconfigurationtype.h <span style="color: grey">(e1efbf38b46fa4456ccc3f3b4e9d918dd3b6074f)</span></li>
<li>language/backgroundparser/backgroundparser.h <span style="color: grey">(8546913621a28978d01135e1c0610eea5602fcf9)</span></li>
<li>language/codecompletion/codecompletionitem.h <span style="color: grey">(1d83e438b3b96e359d12bfb30a357860e2faa7dc)</span></li>
<li>language/codegen/applychangeswidget.h <span style="color: grey">(3a9122373766d828e1a398f3ce8e3051d5795adf)</span></li>
<li>language/codegen/codegenerator.h <span style="color: grey">(8e1b1e03f5201eaef885bcf1fdd83bda2cde388a)</span></li>
<li>language/codegen/codegenerator.cpp <span style="color: grey">(e399965d701739959b4cd45d7f1ce8af036bdd5e)</span></li>
<li>language/codegen/templaterenderer.h <span style="color: grey">(ed5bdba0da74177c021c6a5818f8fc629976c626)</span></li>
<li>language/codegen/utilities.h <span style="color: grey">(00f9e62d19abebbbcddb51725e4f377f1443e7da)</span></li>
<li>language/duchain/aliasdeclaration.h <span style="color: grey">(ea201ac6f112239d32b7957621b2ac4cb8dc33b7)</span></li>
<li>language/duchain/builders/abstractcontextbuilder.h <span style="color: grey">(6c77d86cb275ed0d1b852f0d21349b554e651759)</span></li>
<li>language/duchain/builders/abstractdeclarationbuilder.h <span style="color: grey">(45040b46d1cebeb15dfedc5839c1bf5682a31129)</span></li>
<li>language/duchain/builders/abstractusebuilder.h <span style="color: grey">(36367027949ca0fa38d426c929ccbf1c650ce008)</span></li>
<li>language/duchain/declaration.h <span style="color: grey">(27270bdb7c76903ea4e40711340143a67562265e)</span></li>
<li>language/duchain/declarationid.h <span style="color: grey">(775c3cf86066b2df77059ee8bcfcf01ba97a5a57)</span></li>
<li>language/duchain/definitions.h <span style="color: grey">(fdf882f42b2b23b1dacdb212ca059f998c841fb5)</span></li>
<li>language/duchain/duchain.h <span style="color: grey">(56162d4ef416b0dcb0d9d1197445f7ff571372d4)</span></li>
<li>language/duchain/duchainbase.h <span style="color: grey">(c7cae377df9ea4d488dab63ebba367beb75c1b5f)</span></li>
<li>language/duchain/duchainregister.h <span style="color: grey">(8b3dfa741074cf4a56a3660de95877d79ce6a78f)</span></li>
<li>language/duchain/duchainutils.h <span style="color: grey">(1f550b752811d7e9f12a54f69cdfdf817b41fc1a)</span></li>
<li>language/duchain/ducontext.h <span style="color: grey">(2475132b5f606e42e8263debddb68d186fc69861)</span></li>
<li>language/duchain/dumpdotgraph.h <span style="color: grey">(85ac59d2ee82acd023e2e13ea43d8d7067daf1d7)</span></li>
<li>language/duchain/forwarddeclaration.h <span style="color: grey">(7b103d7d7a19475066326ad19d6d37adefad9a78)</span></li>
<li>language/duchain/navigation/abstractincludenavigationcontext.h <span style="color: grey">(ac6e59dae3618f348b43238e91c3967d00341500)</span></li>
<li>language/duchain/navigation/abstractnavigationcontext.h <span style="color: grey">(1f924505ad9056324f2d0fa936ab041f22ed2459)</span></li>
<li>language/duchain/persistentsymboltable.h <span style="color: grey">(3c6cfddf6b51d1239ca0b7b11a3dd2929e216ada)</span></li>
<li>language/duchain/topducontext.h <span style="color: grey">(2e50164724947c8ffaaf1269a5a9063f50a97268)</span></li>
<li>language/duchain/topducontextdynamicdata.h <span style="color: grey">(fd7cbc1aedbdc83351966b64e369e561449e5296)</span></li>
<li>language/interfaces/ilanguagesupport.h <span style="color: grey">(9ac7f369067be3eec84e5016e54018359705c0da)</span></li>
<li>language/interfaces/iquickopen.h <span style="color: grey">(855a8ec9a48b5d7433bb7256a66b6ff68402164f)</span></li>
<li>outputview/ioutputview.h <span style="color: grey">(6e937f8d70cf21c1cef8ff73824aada4c0922b76)</span></li>
<li>plugins/contextbrowser/browsemanager.h <span style="color: grey">(2ccf313126ba74a3303949b1624875bd6a38fc94)</span></li>
<li>plugins/externalscript/externalscriptplugin.h <span style="color: grey">(645a9c8b64edb325a62043ce48918f7a05db3512)</span></li>
<li>plugins/filetemplates/templateoptionspage.h <span style="color: grey">(898e1b88ca9b47c04a5654a5a724f10f42f4026c)</span></li>
<li>plugins/grepview/grepviewplugin.h <span style="color: grey">(61ae56a491f1bdfa8dfb4afcbe6b7fb5395c08ad)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(ff84cdd2f10685bfffebc6a74c5da36d0f08c00f)</span></li>
<li>plugins/projectmanagerview/projectmodelitemdelegate.cpp <span style="color: grey">(84a923e9f1e270dcc22a2f2831a96e4c49857420)</span></li>
<li>project/interfaces/iprojectfilemanager.h <span style="color: grey">(256c0b2a9d6479e9dc64e03229f3f891d2a693ed)</span></li>
<li>serialization/itemrepository.h <span style="color: grey">(821046705f296522a631d2f436e9ed1b4d1f0488)</span></li>
<li>serialization/referencecounting.h <span style="color: grey">(78b4321641b75be1eb60e39c7fc2561e161b4746)</span></li>
<li>shell/documentcontroller.h <span style="color: grey">(b28c129a7292a179d3f710cd51486eea64dd5aed)</span></li>
<li>shell/launchconfiguration.h <span style="color: grey">(8d80a0f6707bbb390c577538506e9b45a0840c04)</span></li>
<li>shell/launchconfigurationdialog.ui <span style="color: grey">(51e4ae27c5c61d80b2299a698d54d1e742947d97)</span></li>
<li>shell/plugincontroller.h <span style="color: grey">(d5900a3f45317cbb75544e30e3f754fee7c6058d)</span></li>
<li>shell/progresswidget/progressmanager.h <span style="color: grey">(440e35f5fe954086b5b59cf19ff7d6afccd03f9f)</span></li>
<li>shell/sessioncontroller.h <span style="color: grey">(f358540fa53c9d42b67d487d756c95cb82728570)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(2c5d6eac5d8cfa87cf359d98af0d1376886d13cd)</span></li>
<li>sublime/document.h <span style="color: grey">(2e0001373b4cbe6d27d39730876283eed372e3a3)</span></li>
<li>tests/testfile.h <span style="color: grey">(ddf49f45985ecfe429e5bd95f3f69cbf9c517dc2)</span></li>
<li>util/convenientfreelist.h <span style="color: grey">(91eafe74cd4a359c29e42c8b0e3c26440b01418f)</span></li>
<li>util/embeddedfreetree.h <span style="color: grey">(b6df986fd6558e972e619e4eb5d3c4d3017bc04d)</span></li>
<li>util/formattinghelpers.h <span style="color: grey">(04a6bab5204ada823e4f4676fca06fd3056e8eb7)</span></li>
<li>util/pushvalue.h <span style="color: grey">(41434bf31b1ac65ab82c30fddb93cdc1414f954c)</span></li>
<li>vcs/vcsannotation.h <span style="color: grey">(3a22e921648457cffe35837ea8cc66536718bb88)</span></li>
<li>vcs/vcsannotation.cpp <span style="color: grey">(7b94a91d1bdcec6d67e55c21b9e7c1dbc63b218f)</span></li>
<li>vcs/vcslocation.h <span style="color: grey">(6a3c5431ac2664c97924a86bda9e5d5b2a20c77d)</span></li>
<li>vcs/vcslocation.cpp <span style="color: grey">(b1f9252b10dcb583094cb0a424eba1dbb83329c6)</span></li>
<li>vcs/vcsstatusinfo.h <span style="color: grey">(d0e8736cf6077a383e5f47e77e1419bf4eb9c2ea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128530/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>