<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2958" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D2958#59248" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D2958#59248</a>, <a href="https://phabricator.kde.org/p/antonanikin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@antonanikin</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">you call that QtCreator style. I'd say we can find a more meaningful name than that.</li>
</ul></blockquote>
<p>Ok, I will think about new name. Suggestions are welcome :)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">View shortcuts toggle: 2 states (visible, hidden) instead of 3 (visible, focused, hidden).<ul class="remarkup-list">
<li class="remarkup-list-item">would it maybe make sense to just make the 2 states the new default? We can have some discussion WRT how people should give a toolview the focus and what are the use-cases.</li>
</ul></li>
</ul></blockquote>
<p>Maybe I misunderstood you, correct me please. I think we should have 3 states:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">focused - when we open some tool view (with shortcut or "by hand" (mouse click)) we should focus it to do something inside. For example if we show context help it seems to be useful to focus help page for scroll, find, etc with keyboard.</li>
<li class="remarkup-list-item">unfocused - when we return to editor, tool view lost focus, but don't closed.</li>
<li class="remarkup-list-item">hidden - when we use some mechanism for close tool view.
<br /><br />
New behavior uses all 3 states. If we focused inside some tool view and run new "focus or hide" action we go to the editor and tool view will be unfocused. Second action run will close (hide) all unlocked tool views.</li>
</ol></div>
</blockquote>
<p>Focus and unfocused are the same state WRT toolview toggling.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">I see why you want it but I really think it's a corner use-case. I haven't seen a bug report complaining about it. I suggest moving the action to the context menu at least, so we can have some text explaining what it does and so it doesn't add clutter.</li>
</ul></blockquote>
<p>Ok, but for which element we should add such context menu item? Adding it for each tool view seems to be an "overhead" and produce user's confusing. Adding it to whole dock can leads to situation, when we have too many toolviews on some side, which hides dock panel and also "hides" panel's context menu. Maybe we should adds such settings to KDevelop config page? I think "blocking/unblocking" sides is not so frequent operation and this way may be preferable.</p></blockquote>
<p>I think it's better in the toolbar context menu. In the settings page we'll lose the context.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2958" rel="noreferrer">https://phabricator.kde.org/D2958</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antonanikin, KDevelop<br /><strong>Cc: </strong>apol, kdevelop-devel<br /></div>