<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128201/">https://git.reviewboard.kde.org/r/128201/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tl;dr: Sorry, can't be bothered to read through all this huge thread again...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@René: Could you check the following commit and see whether it fixes the appearance of the progressbar + button for you? To me, progressbar + button look perfectly fine on Linux (Breeze style), Windows (W10 style) and OS X (native style) now. Not sure we still need this patch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>commit dbe5d8ebb1fc730c9784c50e7b9c05148bb3f05a
Author: Kevin Funk <kfunk@kde.org>
Date: Mon Sep 5 21:07:15 2016 +0200
Fix style of some buttons, don't raise
(cherry picked from commit bf5ef7f39732fbc990bdf4a1c76acac53b45f2bd)
</pre></div>
</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On September 11th, 2016, 12:39 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and David Faure.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2016, 12:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I came across this old bit of code, judging from the use of the deprecated <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_OS_MAC</code> token.
Some quick testing suggests that using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">WA_LayoutUsesWidgetRect</code> achieves what I think is the intended effect without platform-specific code. (That platform test ought really check for using the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">macintosh</code> widget style btw, rather than "are we running on OS X").</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X and Linux, with the native theme (Qt 5.6.x) as well as QtCurve, Breeze and Oxygen.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/progresswidget/statusbarprogresswidget.cpp <span style="color: grey">(42a58cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128201/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/1498e8dc-4541-473b-b6db-2c2ae138cbc3__Screen_Shot_2016-06-17_at_00.17.17.png">OS X/Mac native *without* the patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/17/dd352994-1753-4b33-a0d2-cd2a3132df48__progress-stock.png">stock widget under Linux (same layout using Breeze)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/8e6a0761-b760-4f41-be67-7f9ba7318349__Screen_Shot_2016-06-18_at_19.21.52.png">OS X/native with the new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/3535be4c-3034-493d-88c0-61ab9a13844d__Screen_Shot_2016-06-18_at_19.24.46.png">OS X using QtCurve with the new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/359d5f57-bdaa-45a7-a0b0-6acb5609459f__Screen_Shot_2016-06-18_at_19.16.19.png">Linux, Breeze, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/f5eb0902-884a-47e5-bf84-a3581a21bece__Screen_Shot_2016-06-18_at_19.14.17.png">Linux, QtCurve, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/536d4f09-8409-4eb4-80ca-27d3f744d6a0__Screen_Shot_2016-06-18_at_19.16.56.png">Linux, Oxygen, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/19/ee2d687e-69ea-493f-9ae4-87d90be614e2__progress-patched-breeze.png">Linux, Breeze + Breeze icons, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/19/7e3cfc5c-cb80-491c-b4d2-4d6f9c839a48__progress-patched-qtcurve.png">Linux, QtCurve + Breeze icons, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/19/0b10d97d-3ba6-4d05-a663-3a03e29bc1c9__progress-patched-oxygen.png">Linux,Oxygen+Breeze icons, new patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/19/2a5b48bf-38f1-4ba9-a291-5de65537f8e1__progress-patched-breeze2.png">Linux, Breeze, new patch with maximumHeight from progressBar->sizeHint().height()</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/346b2bdb-6577-416b-80ff-dc16ff4f5a27__Screen_Shot_2016-06-20_at_12.27.58.png">X11, Breeze style + icons</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/9693a989-5e2b-476a-bf61-90bff8532cef__Screen_Shot_2016-06-20_at_12.29.13.png">X11, Oxygen style, Breeze icons</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/8ef04667-1ef7-4a5f-915b-364a90dbca4a__Screen_Shot_2016-06-20_at_12.30.04.png">X11, QtCurve style, Breeze icons</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/0ab45b09-ba1e-4987-b431-c7b0869e23a2__Screen_Shot_2016-06-20_at_12.31.17.png">X11, Oxygen style & icons</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/b43b065e-7b1f-4c3f-8548-0c60842c81c6__xzHbU.png">X11, Oxygen style & icons, expanded state</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/4801a619-3092-4b51-8549-36867189fdd9__Screen_Shot_2016-06-20_at_12.48.34.png">X11, Breeze, no "additional adjustments"</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/20/f9db48ac-4a0d-4574-8daf-bcfd3781baf0__Screen_Shot_2016-06-20_at_12.48.56.png">X11, Oxygen, taller progbar due to "no additional adjustments"</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/11/9596660e-c169-44eb-80c5-3528d9a7cd08__UpArrow-MacNative.png">progress widget under the pure native Macintosh style, using Qt::UpArrow</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/11/eda05b11-4fac-4229-bcfd-9fc0997e19f8__UpArrow-Breeze.png">progress widget under Breeze, using Qt::UpArrow</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>