<table><tr><td style="">antonanikin retitled this revision from "Final step for use-nullptr" to "Next step for use-nullptr".<br />antonanikin updated the summary for this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-n3oxls3oyndc2nz/" rel="noreferrer">(Show Details)</a><br />antonanikin updated this revision to Diff 7479.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3087" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>EDIT DETAILS</strong><div><div style="white-space: pre-wrap; color: #74777D;"><span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">The patch finalize</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">The patch continues use-nullptr migration with changes for some parts of code which was not fixed by clang-tidy.<br />
<br />
Unfortunately it's not possible now to enable "-Wzero-as-null-pointer-constant" flag without adding many ugly fixes to code.</span> <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">use-nullptr migration</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">It causes</span> by <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">adding "-Werror=zero-as-null-pointer-constant" compiler flag and nullptr-changes</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">warnings/errors produced by this flag</span> for <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">some parts of code which was not fixed by clang-tidy.<br />
<br />
For Subversion plugin this patch provide workaround for</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">3rd-party,</span> <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">successful compilation (sets "-Wno-error=zero-as-null-pointer-constant" flag).</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">non-KDevelop code such a KF5,</span> <span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">It is necessary due using of Subversion library C API which breaks new "</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);">Qt which still use old-style zeroes instead </span>nullptr<span style="padding: 0 2px; color: #802b2b; background: rgba(251, 175, 175, .7);">"-style</span><span style="padding: 0 2px; color: #3e6d35; background: rgba(151, 234, 151, .6);"></span>.</div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D3087?vs=7464&id=7479" rel="noreferrer">https://phabricator.kde.org/D3087?vs=7464&id=7479</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3087" rel="noreferrer">https://phabricator.kde.org/D3087</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>documentation/documentationfindwidget.h<br />
interfaces/idocumentation.h<br />
interfaces/iplugincontroller.h<br />
interfaces/iuicontroller.h<br />
language/duchain/appendedlist.h<br />
language/duchain/classdeclaration.h<br />
language/duchain/duchainlock.h<br />
language/duchain/duchainpointer.h<br />
language/duchain/duchainregister.h<br />
language/duchain/duchainutils.h<br />
language/duchain/functiondefinition.h<br />
language/duchain/indexeddeclaration.h<br />
language/duchain/indexedducontext.h<br />
language/duchain/indexedtopducontext.h<br />
language/duchain/localindexeddeclaration.h<br />
language/duchain/navigation/navigationaction.h<br />
language/duchain/parsingenvironment.h<br />
language/duchain/topducontext.h<br />
language/duchain/topducontextutils.h<br />
language/duchain/types/arraytype.h<br />
language/duchain/types/constantintegraltype.h<br />
language/duchain/types/delayedtype.h<br />
language/duchain/types/enumerationtype.h<br />
language/duchain/types/enumeratortype.h<br />
language/duchain/types/functiontype.h<br />
language/duchain/types/integraltype.h<br />
language/duchain/types/pointertype.h<br />
language/duchain/types/referencetype.h<br />
language/duchain/types/structuretype.h<br />
language/duchain/types/typealiastype.h<br />
language/duchain/types/typepointer.h<br />
language/duchain/types/typeutils.h<br />
language/util/basicsetrepository.h<br />
language/util/setrepository.h<br />
plugins/appwizard/appwizarddialog.h<br />
plugins/appwizard/appwizardpagewidget.h<br />
plugins/filetemplates/templateclassassistant.cpp<br />
plugins/subversion/kdevsvncpp/client.hpp<br />
plugins/subversion/kdevsvncpp/entry.hpp<br />
plugins/subversion/kdevsvncpp/info.hpp<br />
plugins/subversion/kdevsvncpp/pool.hpp<br />
plugins/subversion/kdevsvncpp/property.hpp<br />
plugins/subversion/kdevsvncpp/status.hpp<br />
plugins/subversion/kdevsvncpp/targets.hpp<br />
serialization/itemrepository.h<br />
serialization/repositorymanager.h<br />
shell/core.h<br />
sublime/areaindex.h<br />
tests/json/jsondeclarationtests.h<br />
util/convenientfreelist.h<br />
util/embeddedfreetree.h<br />
vcs/vcsjob.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>antonanikin, kfunk, KDevelop<br /><strong>Cc: </strong>kfunk, kdevelop-devel<br /></div>