<table><tr><td style="">brauch requested changes to this revision.<br />brauch added a reviewer: brauch.<br />brauch added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3073" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks for the patch -- see below for a few nitpicks :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3073#inline-11841" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">branchmanager.cpp:202</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">messageBox</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">Sorry</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Already on branch </span><span style="color: #bb6622">\"</span><span style="color: #766510">%1</span><span style="color: #bb6622">\"\n</span><span style="color: #766510">"</span><span class="p">,</span> <span class="n">src</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use KMessageBox::Information, this is not something we need to be sorry about</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3073#inline-11842" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">branchmanager.cpp:206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">srcRev</span><span class="p">.</span><span class="n">setRevisionValue</span><span class="p">(</span><span class="n">src</span><span class="p">,</span> <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">VcsRevision</span><span style="color: #aa2211">::</span><span class="n">GlobalNumber</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #74777d">// We have two options here:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span style="color: #74777d">// * create a regular VcsRevision to represent the last commit on the current branch or</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indent comments please</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3073#inline-11844" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">branchmanager.cpp:229</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">VCSDiffPatchSource</span><span style="color: #aa2211">*</span> <span class="n">patch</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">VCSDiffPatchSource</span><span class="p">(</span><span class="n">d</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">showVcsDiff</span><span class="p">(</span><span class="n">patch</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">also use auto ;)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3073#inline-11845" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">branchmanager.cpp:233</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">error</span><span class="p">(</span><span class="n">ICore</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">uiController</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">activeMainWindow</span><span class="p">(),</span> <span class="n">vcsjob</span><span style="color: #aa2211">-></span><span class="n">errorString</span><span class="p">(),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Unable to get difference."</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I suggest "Unable to retrieve diff", this string is strange.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3073#inline-11843" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">branchmanager.ui:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">       <property name="text">
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <string>Diff From</string>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">       </property>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Differences to"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3073" rel="noreferrer">https://phabricator.kde.org/D3073</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>coliveira, apol, kfunk, brauch<br /><strong>Cc: </strong>brauch, kdevelop-devel<br /></div>