<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129108/">https://git.reviewboard.kde.org/r/129108/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Radu Benea.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2016, 9:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">reordered declaration of short unsigned int as kdevelop would generate it
I did some testing and managed to discover the source of the missing type qualifiers.
Apparently decltype is initialized as a deferredType but all type info is discovered, than it gets updated and discarded.
The following hack seems to fix the decltype test. I don't understand enough about clang to come up with the proper solution.
@@ -326,11 +326,11 @@ struct Visitor
AbstractType *dispatchType(CXType type, CXCursor cursor)
{
IF_DEBUG(clangDebug() << "TK:" << type.kind;)
auto kdevType = createType<TK>(type, cursor);
- if (kdevType) {
+ if (kdevType && !kdevType->modifiers()) {
setTypeModifiers<TK>(type, kdevType);
}
return kdevType;
}
//BEGIN dispatch*</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">added test to check decltype type deduction support in clang</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/clang/tests/test_duchain.h <span style="color: grey">(e4bd5dd)</span></li>
<li>languages/clang/tests/test_duchain.cpp <span style="color: grey">(987b5ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129108/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>