<table><tr><td style="">antonanikin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2840" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good, thanks.</p>

<p>I also had a very brief first look, and my remarks are:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Your TODO about removing hard-coded CLANG_TIDY_PATH - good idea, do it.</li>
</ol>

<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Check code reworked from kdev-cppcheck for unused parts. My main remark - confusing comments, which seems to be an incorrect for your app (see job.cpp for example).</li>
</ol>

<ol class="remarkup-list" start="3">
<li class="remarkup-list-item">Per-project configuration code looks a bit complicated and redundant. I think it will be good to reimplement per-project configuration with using standard KConfigSceleton approach.  This way allows you to drop(or simplify) some "boring" code like a manually created <tt style="background: #ebebeb; font-size: 13px;">apply()</tt> methods for Config Pages. My last version of kdev-cppcheck (differential <a href="https://phabricator.kde.org/D2844" class="remarkup-link" target="_blank" rel="noreferrer">D2844</a>) already uses this approach.</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2840#inline-11262" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin.cpp:251</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">core</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">uiController</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">findToolView</span><span class="p">(</span><span class="n">i18nd</span><span class="p">(</span><span style="color: #766510">"kdevproblemreporter"</span><span class="p">,</span> <span style="color: #766510">"Problems"</span><span class="p">),</span> <span style="color: #aa4000">nullptr</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                                             <span class="n">KDevelop</span><span style="color: #aa2211">::</span><span class="n">IUiController</span><span style="color: #aa2211">::</span><span class="n">FindFlags</span><span style="color: #aa2211">::</span><span class="n">Raise</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it's better to use new API:<br />
<tt style="background: #ebebeb; font-size: 13px;">core()->languageController()->problemModelSet()->showModel(problemModelName);</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R218 KDev Clang-Tidy Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2840" rel="noreferrer">https://phabricator.kde.org/D2840</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>coliveira, mwolff, apol, kfunk, antonanikin<br /><strong>Cc: </strong>kdevelop-devel<br /></div>