<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126685/">https://git.reviewboard.kde.org/r/126685/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Igor Kushnir.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2016, 5:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the implementation where the two larger navigation widgets are in the top row and all the tool buttons are in the bottom row.
I prefer this version over the swapped-rows one.
The relevant screenshots can be found in my old google drive links: kdevelop-documentation-view-screenshots/2-rows-icons-at-bottom-no-separators/ and documentation-find-no-text-screenshots/
This review request is unpopular because of its UI clutter and implementation complexity with breaking KDevPlatform API changes.
So I'm going to provide yet another implementation of the zoom feature in a new review request in a few days or weeks.
This time I plan to:
1. Place the three new actions into a QWebView context menu to avoid UI clutter.
One disadvantage is that repeatedly clicking a zoom button would be more tedious in this case.
2. Save zoom factor on a per-view basis.
Since the documentation fonts differ a lot, it may be useful to have different zoom factors for each documentation provider.
This will hopefully allow a simpler implementation without complex dependencies.
René,
- Ctrl+0 is already occupied by another action (Open Configuration...).
Besides this shortcut would make more sense for the code editing widget than for the relatively insignificant documentation widget.
I'll hopefully be able to allow setting custom shortcuts to all 3 new zoom actions.
- This particular implementation (mouse scrolls, tool buttons and QWebView::setZoomFactor) can not be easily adapted to allow changing font family.
You could introduce this functionality later (using QWebSettings I guess).
I don't think that it is possible to implement the font configuration functionality for all KDevelop views at once.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add zoom support for documentation view</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built, installed, run tests.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>documentation/CMakeLists.txt <span style="color: grey">(ff57e258ab5c62ce737c4013005247d585e87b61)</span></li>
<li>documentation/documentationview.h <span style="color: grey">(c7a0822767c1f535527dbf8830e5dc70fd2f818a)</span></li>
<li>documentation/documentationview.cpp <span style="color: grey">(a927ab65ae83e3eaf10cfe99a8570eed5c65c53c)</span></li>
<li>documentation/documentationzoom.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>documentation/documentationzoom.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>documentation/standarddocumentationview.h <span style="color: grey">(3f429752032be6fa2b0b49fb3094f7bf31a28367)</span></li>
<li>documentation/standarddocumentationview.cpp <span style="color: grey">(a9185fd592771f9ead7d4216e08f8c93abab601a)</span></li>
<li>interfaces/idocumentation.h <span style="color: grey">(7673e5fe58ab736d864328b0c8c6b087b197867b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126685/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>