<table><tr><td style="">nicolaih created this revision.<br />Restricted Application added a subscriber: kdevelop-devel.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2649" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>For the purpose of determining where custom defines and includes should<br />
be added, the final location of the diagnostic is irrelevant: it's the<br />
path to the compilation unit itself that matters, since that's where the<br />
corresponding configuration is taken from.</p>

<p>If you have a missing include file in an include file, compilationUnit()<br />
gives the path in which a custom include should be added, unlike<br />
finalLocation().</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVELOP KDevelop</div></div></div><br /><div><strong>BRANCH</strong><div><div>pub-includes1-compilation-unit</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2649" rel="noreferrer">https://phabricator.kde.org/D2649</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>languages/clang/duchain/clangproblem.cpp<br />
languages/clang/duchain/clangproblem.h<br />
languages/clang/duchain/missingincludepathproblem.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>nicolaih<br /><strong>Cc: </strong>kdevelop-devel<br /></div>