<table><tr><td style="">volden created this revision.<br />volden added a reviewer: KDevelop.<br />volden added a subscriber: kdevelop-devel.<br />volden set the repository for this revision to rKDEVPLATFORM KDevPlatform.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2192" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Move the implementation of hasError and setHasError to iplugin. They are basically just getter/setters and actual implementation belong there - not in the individual plug-ins. <br />
Unified the way plug-ins report errors when failing.</p>

<p>There is a separate patch for plug-ins in Kdevelop repository.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2192" rel="noreferrer">https://phabricator.kde.org/D2192</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>interfaces/iplugin.cpp<br />
interfaces/iplugin.h<br />
plugins/bazaar/bazaarplugin.cpp<br />
plugins/bazaar/bazaarplugin.h<br />
plugins/git/gitplugin.cpp<br />
plugins/git/gitplugin.h<br />
plugins/konsole/kdevkonsoleviewplugin.cpp<br />
plugins/konsole/kdevkonsoleviewplugin.h<br />
plugins/perforce/perforceplugin.cpp<br />
plugins/perforce/perforceplugin.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>volden, KDevelop<br /><strong>Cc: </strong>kdevelop-devel<br /></div>