<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128188/">https://git.reviewboard.kde.org/r/128188/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2016, 2 p.m. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128188/diff/6/?file=471144#file471144line185" style="color: black; font-weight: bold; text-decoration: underline;">shell/progresswidget/statusbarprogresswidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">185</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">MacDockProgressView</span><span class="o">::</span><span class="n">setRange</span><span class="p">(</span> <span class="mi">0</span><span class="p">,</span> <span class="mi">100</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-1 for making this all static, or can there really just be one dock progress view?</p></pre>
</blockquote>
<p>On July 10th, 2016, 2:23 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, there is only 1 Dock tile per application instance. Windows can be shown as individual tiles in a specific part of the Dock, but only when they're minimised (and the user didn't change the corresponding option).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So the only way to have multiple progress views would be to draw more than one on the single Dock tile. That's possible of course, but do you really think that's a good idea when you look at the screenshots</p></pre>
</blockquote>
<p>On July 10th, 2016, 11:52 p.m. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, nvm then. And +1 to merge it in for now, but please, pretty please, move this together with the unity stuff into a proper framework. <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kwidgetsaddons</code> comes into mind.</p></pre>
</blockquote>
<p>On July 11th, 2016, 7:16 a.m. CEST, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is currently a Window Metadata framework being worked on which this should go into.</pre>
</blockquote>
<p>On July 11th, 2016, 8:43 a.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Window or <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Windows</em>? I don't really see how job/task progress relates to window-specific metadata, but I suppose the framework's description will make that clear.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And for the record: I think I've already said it but I'm all for putting this sort of thing in a framework or library where it can serve other applications as well. I only won't have much opportunity to do much development for the next couple of weeks.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We should also watch the Qt mailing lists. I brought up the suggestion to add this kind of feature to Qt itself and that was rather well received.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In the meantime I committed this (http://commits.kde.org/kdevplatform/c0626300e1c18448dd653a3484fd1ca6298e2d8c; hoping I didn't mis-interpret Milian's remark above). This RR should have been closed but I got an error I never saw before:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">> git push
Counting objects: 9, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 3.10 KiB | 0 bytes/s, done.
Total 9 (delta 7), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote: File "/home/git/repo-management/hooks/update_review.py", line 160, in <module>
remote: main()
remote: File "/home/git/repo-management/hooks/update_review.py", line 156, in main
remote: close_review(review_id, commit_id, committer, author, ref_change)
remote: File "/home/git/repo-management/hooks/update_review.py", line 110, in close_review
remote: data=dict(status="submitted", close_description=message))
remote: File "/usr/lib/python3/dist-packages/requests/api.py", line 105, in put
remote: return request('put', url, data=data, **kwargs)
remote: File "/usr/lib/python3/dist-packages/requests/api.py", line 49, in request
remote: return session.request(method=method, url=url, **kwargs)
remote: File "/usr/lib/python3/dist-packages/requests/sessions.py", line 443, in request
remote: prep = self.prepare_request(req)
remote: File "/usr/lib/python3/dist-packages/requests/sessions.py", line 374, in prepare_request
remote: hooks=merge_hooks(request.hooks, self.hooks),
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 307, in prepare
remote: self.prepare_body(data, files, json)
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 452, in prepare_body
remote: body = self._encode_params(data)
remote: File "/usr/lib/python3/dist-packages/requests/models.py", line 97, in _encode_params
remote: v.encode('utf-8') if isinstance(v, str) else v))
remote: UnicodeEncodeError: 'utf-8' codec can't encode character '\udcc3' in position 69: surrogates not allowed
remote: This commit is available for viewing at:
remote: http://commits.kde.org/kdevplatform/c0626300e1c18448dd653a3484fd1ca6298e2d8c
To ssh://git@git.kde.org/kdevplatform
8d0fcb8..c062630 master -> master
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any idea if that's due to what I pushed?</p></pre>
<br />
<p>- René J.V.</p>
<br />
<p>On July 5th, 2016, 8:32 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDevelop.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated July 5, 2016, 8:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a follow-up to https://git.reviewboard.kde.org/r/127050/, providing a job progress indication in the Dock (and app switcher), by badging the application icon.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it correct that the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">RunController</code> is not used by the (Clang) parser? If so, shouldn't this progress indication (and the Unity one) be moved to the method that updates the progress bar in KDevelop's lower right corner?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works on OS X 10.9.5 with Qt 5.6.0 and frameworks 5.22.0</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(19a9560)</span></li>
<li>shell/macdockprogressview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/macdockprogressview.mm <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/progresswidget/statusbarprogresswidget.cpp <span style="color: grey">(1a32ea8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128188/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/e800031a-378b-46fb-88cf-ee55c78d7a1f__Screen_Shot_2016-06-14_at_20.30.55.png">progress badge on a Dock icon</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/295a93b7-3802-4501-b2dc-3bdf8fa4048b__Screen_Shot_2016-06-15_at_00.02.05.png">dock icon with progress bar</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>