<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128290/">https://git.reviewboard.kde.org/r/128290/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Kevin Funk.</div>
<div>By Sven Brauch.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This replaces the whitespaceSensitivity() API which allowed languages to decide whether they are sensitive to whitespace changes, and instead introduces a function</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">virtual int suggestedReparseDelayForChange(KTextEditor::Document* doc, const KTextEditor::Range& changedRange,
const QString& changedText, bool removal) const;
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in ILanguageSupport which can be overriden. Languages can choose that the signalled change does not require an update at all (white-space in some languages), that an update should happen with the default delay, or give a custom delay in ms. The default implementation indicates an update with the default delay if the change was not whitespace-only or was whitespace but adjacent to a word.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In kdev-clang, this enables us to do something like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">int</span> <span style="color: #008000; font-weight: bold">ClangSupport</span><span style="color: #666666">:</span><span style="color: #AA22FF">:suggestedReparseDelayForChange</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">KTextEditor</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Document</span><span style="color: #666666">*</span> <span style="color: #408080; font-style: italic">/*doc*/</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">KTextEditor</span><span style="color: #666666">:</span><span style="color: #AA22FF">:Range</span><span style="color: #666666">&</span> <span style="color: #408080; font-style: italic">/*changedRange*/</span><span style="color: #666666">,</span>
<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">QString</span><span style="color: #666666">&</span> <span style="color: #008000; font-weight: bold">changedText</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">bool</span> <span style="color: #408080; font-style: italic">/*removal*/</span><span style="color: #666666">)</span> <span style="color: #008000; font-weight: bold">const</span>
{
if ( changedText<span style="color: #666666">.</span>contains(QLatin1Char(<span style="color: #BA2121">'\n'</span>)) <span style="color: #666666">||</span> changedText<span style="color: #666666">.</span>contains(QLatin1Char(<span style="color: #BA2121">';'</span>)) ) <span style="border: 1px solid #FF0000">{</span>
return ILanguageSupport<span style="color: #666666">::</span>DefaultDelay;
}
<span style="color: #008000; font-weight: bold">return</span> <span style="color: #008000; font-weight: bold">3000</span><span style="color: #666666">;</span>
<span style="border: 1px solid #FF0000">}</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(will submit separately), which makes completion feel much more snappy (Kevin knows ;)). I actually think I will do something similar in kdev-python, namely recommend an instant re-parse when a newline is added.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/backgroundparser/backgroundparser.h <span style="color: grey">(bf22d38)</span></li>
<li>language/backgroundparser/backgroundparser.cpp <span style="color: grey">(84e4011)</span></li>
<li>language/backgroundparser/documentchangetracker.h <span style="color: grey">(079feab)</span></li>
<li>language/backgroundparser/documentchangetracker.cpp <span style="color: grey">(4ddded5)</span></li>
<li>language/interfaces/ilanguagesupport.h <span style="color: grey">(5c3fc30)</span></li>
<li>language/interfaces/ilanguagesupport.cpp <span style="color: grey">(67aab36)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128290/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>