<table><tr><td style="">kfunk added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1871" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Heya, checked your patch:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">testing your patch. first observation: ctrl+alt+o opens a dialog now</li>
<li class="remarkup-list-item">second: ctrl+alt+o + esc doesn't give back focus to the editor</li>
<li class="remarkup-list-item">third: crash on exit: <a href="https://paste.kde.org/pjl6gtebv" class="remarkup-link" target="_blank" rel="noreferrer">https://paste.kde.org/pjl6gtebv</a></li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1871" rel="noreferrer">https://phabricator.kde.org/D1871</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>tcanabrava, apol, kfunk<br /><strong>Cc: </strong>arichardson, kdevelop-devel<br /></div>