<table><tr><td style="">arichardson added inline comments.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1871" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1871#inline-7276" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">quickopenplugin.cpp:459</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">connect</span><span class="p">(</span> <span class="n">dialog</span><span style="color: #aa2211">-></span><span class="n">widget</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QuickOpenWidget</span><span style="color: #aa2211">::</span><span class="n">scopesChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QuickOpenPlugin</span><span style="color: #aa2211">::</span><span class="n">storeScopes</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">  <span class="bright"></span><span style="color: #74777d"><span class="bright">//Not connecting itemsChanged to storeItems, as showQuickOpen doesn't use lastUsedItems and so shouldn't store item changes</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">  <span style="color: #74777d">//connect( dialog->widget(), SIGNAL(itemsChanged(QStringList)), this, SLOT(storeItems(QStringList)) );</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  <span class="bright">  </span><span class="n"><span class="bright">connect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">dialog</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">widget</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">SIGNAL</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">itemsChanged</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright"></span><span class="p"><span class="bright">)),</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">this</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">SLOT</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">storeItems</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">QStringList</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span><span class="bright"> </span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">dialog</span><span style="color: #aa2211">-></span><span class="n">widget</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">ui</span><span class="p">.</span><span class="n">itemsButton</span><span style="color: #aa2211">-></span><span class="n">setEnabled</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">  <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">quickOpenLine</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">quickOpenLine</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">showWithWidget</span><span class="p">(</span><span class="n">dialog</span><span style="color: #aa2211">-></span><span class="n">widget</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">dialog</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">  <span class="p">}</span><span style="color: #aa4000">else</span><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use new connect syntax?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1871" rel="noreferrer">https://phabricator.kde.org/D1871</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>tcanabrava, apol, kfunk<br /><strong>Cc: </strong>arichardson, kdevelop-devel<br /></div>