<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127749/">https://git.reviewboard.kde.org/r/127749/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just a technical/code review -- will look over the functionality as soon as it is in a separate repo and I can build it :)</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line38" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>
<p>embedded.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>38</th>
<td><pre> <span class="n">actionProject</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"1 Line Tip"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line40" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>
<p>embedded.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>40</th>
<td><pre> <span class="n">actionProject</span><span class="o">-></span><span class="n">setIcon</span><span class="p">(</span> <span class="n">QIcon</span><span class="o">::</span><span class="n">fromTheme</span><span class="p">(</span> <span class="n">QStringLiteral</span><span class="p">(</span><span class="s">"project-development-new-template"</span><span class="p">)</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The way you select whether you have a space behind a parenthesis or not is confusing ;)
I'd suggest to either always or never have one (I prefer never)</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line46" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>
<p>embedded.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>46</th>
<td><pre> <span class="n">actionConfigureBoard</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"1 Line Tip"</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line51" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>
<p>embedded.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>51</th>
<td><pre><span class="kt">void</span> <span class="n">Embedded</span><span class="o">::</span><span class="n">documentDeclaration</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This function name is very confusing.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line36" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>
<p>embedded.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>36</th>
<td><pre> <span class="n">actionCollection</span><span class="p">()</span><span class="o">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">actionProject</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Alt+Shift+a"</span> <span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think this action is frequently used enough to have a default shortcut ... how often do you use this? five times a year?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line22" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>22</th>
<td><pre> <span class="k">struct</span> <span class="n">coluns</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">coluns?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line6" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>6</th>
<td><pre><span class="cp">#include <Qt></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think you need this if you include e.g. QDialog -- I've never seen it anywhere</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line1" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1</th>
<td><pre><span class="cp">#ifndef ARDUINOWINDOW_H</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this file is missing a copyright header (as are several others)</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line69" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>69</th>
<td><pre><span class="n">class</span> <span class="nl">arduinoWindow</span> <span class="p">:</span> <span class="n">public</span> <span class="n">QDialog</span><span class="p">,</span> <span class="n">Ui</span><span class="o">::</span><span class="n">arduinowindow</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">please use uppercase names for classes
Also, you inherit from Ui::arduinowindow and then you have a meber of that type as well? that seems wrong</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line32" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>32</th>
<td><pre> <span class="kt">bool</span> <span class="nf">populate</span><span class="p">(</span><span class="n">QStringList</span> <span class="n">ids</span><span class="p">,</span> <span class="n">QStringList</span> <span class="n">names</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why don't you simply store the two vectors? that doesn't seem more difficult to use in any place than the pairs and saves a lot of code ...</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line42" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>
<p>arduinowindow.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>42</th>
<td><pre> <span class="n">QStringList</span> <span class="n">boardsId</span> <span class="o">=</span> <span class="n">Board</span><span class="o">::</span><span class="n">instance</span><span class="p">().</span><span class="n">boardList</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">const &</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line37" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>
<p>arduinowindow.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>37</th>
<td><pre> <span class="n">db</span><span class="p">.</span><span class="n">push_back</span><span class="p">(</span><span class="n">coluns</span><span class="p">{</span><span class="n">ids</span><span class="p">[</span><span class="n">i</span><span class="p">],</span> <span class="n">names</span><span class="p">[</span><span class="n">i</span><span class="p">]});</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Technically speaking, you have to call beginResetModel / endResetModel here.
I'd also suggest to move this implementation to the .cpp file.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line92" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>
<p>arduinowindow.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>92</th>
<td><pre> <span class="k">delete</span> <span class="n">ui</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also just use some way of automatic memory management (e.g. QScopedPointer).</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line7" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>
<p>arduinowindow.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>7</th>
<td><pre><span class="cp">#include <QCoreApplication></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">?? :D
also below, those includes seem a bit random, I don't think you need them</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line139" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>
<p>firsttimewizard.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>139</th>
<td><pre> <span class="c1">// call tar to extract</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh no please don't. Use KArchive.
Network with QNMA is ok, but KIO::copy would probably be simpler there as well</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line230" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>
<p>firsttimewizard.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>230</th>
<td><pre> <span class="n">path</span> <span class="o">=</span> <span class="n">QFileDialog</span><span class="o">::</span><span class="n">getExistingDirectory</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Find Files"</span><span class="p">),</span> <span class="n">QDir</span><span class="o">::</span><span class="n">currentPath</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do we need an OS switch here? QFileDialog works the same on all those operating systems.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line244" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>
<p>firsttimewizard.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>244</th>
<td><pre> <span class="n">path</span> <span class="o">=</span> <span class="n">QFileDialog</span><span class="o">::</span><span class="n">getExistingDirectory</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Find Files"</span><span class="p">),</span> <span class="n">QDir</span><span class="o">::</span><span class="n">currentPath</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also here, why the #ifdef</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2968/#source/line11" style="color: black; font-weight: bold; font-size: 9pt;">toolkit.cpp</a>
<p>toolkit.cpp</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>11</th>
<td><pre> <span class="n">QFile</span> <span class="n">file</span><span class="p">(</span><span class="n">path</span> <span class="o">+</span> <span class="s">"/hardware/arduino/avr/boards.txt"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">put the path in a local variable</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2969/#source/line1" style="color: black; font-weight: bold; font-size: 9pt;">toolkit.h</a>
<p>toolkit.h</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1</th>
<td><pre><span class="cp">#ifndef TOOLKIT_H</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">generic header guard names are always a source of infinite fun when somebody else uses the same one ;)</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2957/#source/line5" style="color: black; font-weight: bold; font-size: 9pt;">CMakeLists.txt</a>
<p>CMakeLists.txt</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>5</th>
<td><pre>set(ARDUINO_SDK_VERSION_NAME "1.6.8")</pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It makes sense to define those here. But then you should use configure_file to write them out, and also use that to check the version in the code</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127749/file/2957/#source/line8" style="color: black; font-weight: bold; font-size: 9pt;">CMakeLists.txt</a>
<p>CMakeLists.txt</p>
<div>
<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>8</th>
<td><pre>add_definitions(-DARDUINO_SDK_VERSION="${ARDUINO_SDK_VERSION}")</pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use configure_file instead</p></pre>
</div>
<br />
<p>- Sven Brauch</p>
<br />
<p>On April 26th, 2016, 3:05 a.m. UTC, patrick pereira wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Sven Brauch, Kevin Funk, and Tomaz Canabrava.</div>
<div>By patrick pereira.</div>
<p style="color: grey;"><i>Updated April 26, 2016, 3:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Embedded plugin for KDevelop</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Review of embedded plugin for KDevelop
Plugin created to help the development of embedded systems.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">.
|-- CMakeLists.txt
|-- README.md
|-- arduinowindow.cpp
|-- arduinowindow.h
|-- arduinowindow.ui
|-- boardsimg
| |-- ATmega644c3.svg
| |-- ATtiny85_breadboard.svg
| |-- Adafruit_Atmega32u4_Breakout.svg
| |-- ArduPilotMega_v15_breadboard.svg
| |-- Arduino\ Nano3_breadboard.svg
| |-- Arduino\ Voice\ Shield-v16_breadboard.svg
| |-- Arduino-BLE-LowPower-RevB-final_5_breadboard.svg
| |-- Arduino-Ethernet-v11_breadboard.svg
| |-- Arduino-Fio-v22_breadboard.svg
| |-- Arduino-Mini-v5_breadboard.svg
| |-- Arduino-Pro-Mini-v13_breadboard.svg
| |-- ArduinoBluetoothMatev13_breadboard.svg
| |-- Arduino_ADK_MEGA_2560-Rev3_breadboard.svg
| |-- Arduino_DUE_V02b_breadboard.svg
| |-- Arduino_Esplora_breadboard.svg
| |-- Arduino_Ethernet_breadboard.svg
| |-- Arduino_Leonardo_Rev3_breadboard.svg
| |-- Arduino_MEGA_2560-Rev3_breadboard.svg
| |-- Arduino_Micro_Rev03_breadboard.svg
| |-- Arduino_Pro_breadboard.svg
| |-- Arduino_bt07_breadboard.svg
| |-- Ardumoto\ v13_breadboard.svg
| |-- LICENSE.CC-BY-SA
| |-- NetduinoPlus2.svg
| |-- README.md
| |-- TI_Launchpad_MSP430G2.1_breadboard.svg
| |-- TI_Launchpad_MSP430G2_breadboard.svg
| |-- Teensy_2.0_++_breadboard.svg
| |-- Teensy_2.0_breadboard.svg
| |-- Teensy_3.0+pads_breadboard.svg
| |-- Teensy_3.0_breadboard.svg
| |-- Udoo_dual_breadboard.svg
| |-- Wiring_Sa99.svg
| |-- arduino_Uno_Rev3_breadboard-old.svg
| |-- arduino_Uno_Rev3_breadboard.svg
| |-- arduino_Yun(rev1)_breadboard.svg
| |-- arduino_mini_usb_adapter.svg
| |-- arduino_uno(rev3)-icsp_breadboard.svg
| |-- atlas-sientific_Conductivity\ Circuit_breadboard.svg
| |-- atlas-sientific_D.O.\ Circuit_breadboard.svg
| |-- intel-arduino-galileo_breadboard.svg
| |-- intel-arduino-galileo_gen2_breadboard.svg
| <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-- intel_edison-hirosedf40_breadboard.svg
|-- doc_templates
| |-- CMakeLists.txt
| |-- doxygen_cpp.txt
| |-- phpdoc_php.txt
|</code>-- rest_python.txt
|-- embedded.cpp
|-- embedded.h
|-- embeddedproject
| |-- %{APPNAMELC}.cpp
| |-- %{APPNAMELC}.h
| |-- %{PROJECTDIRNAME}.kdev4
| |-- Makefile
| |-- embeddedproject.kdevtemplate
| |-- main.cpp
| <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-- options.kcfg
|-- firsttimewizard.cpp
|-- firsttimewizard.h
|-- firsttimewizard.ui
|-- kdevembedded.json
|-- kdevembedded.qrc
|-- kdevembedded.rc
|-- patrick.kdev4
|-- toolkit.cpp</code>-- toolkit.h</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127749/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/a8f69b53-9658-4552-8345-16a2f236fed8__CMakeLists.txt">CMakeLists.txt</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/9d614ff1-c625-40b1-8a26-3ca3c6396a6f__README.md">README.md</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6e95cc7f-a880-471f-8300-67c7584ef6fa__arduinowindow.cpp">arduinowindow.cpp</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/29f98560-4081-4820-bc4b-cf0acba65f55__arduinowindow.h">arduinowindow.h</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/14591880-85df-45f7-b192-9059ef1a5a90__embedded.cpp">embedded.cpp</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/3720a34d-40ff-45ad-853c-eb5955bc4287__embedded.h">embedded.h</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/51f2f2ed-605c-49b1-87b7-85f6447c8274__firsttimewizard.cpp">firsttimewizard.cpp</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6171895d-b2ed-4f7d-85e8-c01dd511b17e__firsttimewizard.h">firsttimewizard.h</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/df4ccf03-fce7-43f5-be0e-11e00680ea12__kdevembedded.json">kdevembedded.json</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/82f7d7ad-7e02-433c-aaa5-07fea7a8f66e__kdevembedded.qrc">kdevembedded.qrc</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8f3d5a6d-bb86-48c9-84e7-cd5affcd750b__kdevembedded.rc">kdevembedded.rc</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/eb8ac57a-2b8c-4ba1-93d5-45e6be9d56f2__toolkit.cpp">toolkit.cpp</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/88fa0dc5-af42-418a-84f8-6c1d35502c68__toolkit.h">toolkit.h</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8d22467a-6f78-4c38-92af-c08438c2db13__README.md">README.md</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>