<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127749/">https://git.reviewboard.kde.org/r/127749/</a>
     </td>
    </tr>
   </table>
   <br />









<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line42" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>42</th>
   <td><pre>    <span class="n">QStringList</span> <span class="n">boardsId</span> <span class="o">=</span> <span class="n">Board</span><span class="o">::</span><span class="n">instance</span><span class="p">().</span><span class="n">boardList</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">s/boardsId/boardIds</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line43" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>43</th>
   <td><pre>    <span class="n">QStringList</span> <span class="n">boardsName</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">s/boardsName/boardNames</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line44" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>44</th>
   <td><pre>    <span class="n">foreach</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">boardId</span><span class="p">,</span> <span class="n">boardsId</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if you are using the boardIds just to get the list of the names of the boards, why don't you just use the Board::instance().boards ?</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line77" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>77</th>
   <td><pre>    <span class="n">foreach</span><span class="p">(</span><span class="k">const</span> <span class="n">Solid</span><span class="o">::</span><span class="n">Device</span> <span class="n">device</span><span class="p">,</span> <span class="n">devices</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you used auto above, why not here too?
foreach(const auto& device, devices) { ... }</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line79" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>79</th>
   <td><pre>        <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">be consistent: you are using no brackets on some if's or foreaches (like the one above), and use on others. Please read the kdevelop coding style.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line82" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>82</th>
   <td><pre>            <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"Description</span><span class="se">\t</span><span class="s">:"</span> <span class="o"><<</span> <span class="n">device</span><span class="p">.</span><span class="n">description</span><span class="p">();</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">prefer to use QCDebug</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line39" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>

   <p>arduinowindow.h</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>39</th>
   <td><pre>        <span class="p">}</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why did you create the columns struct insteadof using a QStringList column_id; QStringList column_names? that way you don't need to copy each element on a QVector every time you need to populate thigns, just do column_names = names;</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line64" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>

   <p>arduinowindow.h</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>64</th>
   <td><pre></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this 'getData' method is exactly the same as the data() method, with the exception that it returns a column:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QString Id = model.getData(modelIndex.row()).id;
QString Name = model.data(modelIndex).toString();</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, an empty QString() is (), and not ("").</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2960/#source/line83" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.h</a>

   <p>arduinowindow.h</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>83</th>
   <td><pre>    <span class="n">Ui</span><span class="o">::</span><span class="n">arduinowindow</span> <span class="o">*</span><span class="n">ui</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">unused.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2959/#source/line92" style="color: black; font-weight: bold; font-size: 9pt;">arduinowindow.cpp</a>

   <p>arduinowindow.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>92</th>
   <td><pre>    <span class="k">delete</span> <span class="n">ui</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you are deleting a uncreated variable, = crash.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line37" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>

   <p>embedded.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>37</th>
   <td><pre>    <span class="n">connect</span><span class="p">(</span> <span class="n">actionProject</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">triggered</span><span class="p">(</span><span class="kt">bool</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">documentDeclaration</span><span class="p">())</span> <span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">convert to new style signal.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line45" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>

   <p>embedded.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>45</th>
   <td><pre>    <span class="n">connect</span><span class="p">(</span> <span class="n">actionConfigureBoard</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">triggered</span><span class="p">(</span><span class="kt">bool</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">documentDeclaration2</span><span class="p">())</span> <span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">convert to new style signal.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line53" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>

   <p>embedded.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>53</th>
   <td><pre>  <span class="n">embeddedWindow</span> <span class="o">=</span> <span class="k">new</span> <span class="n">firstTimeWizard</span><span class="p">(</span><span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">uiController</span><span class="p">()</span><span class="o">-></span><span class="n">activeMainWindow</span><span class="p">());</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">memory leak - you never free embeddedWindow.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2961/#source/line59" style="color: black; font-weight: bold; font-size: 9pt;">embedded.cpp</a>

   <p>embedded.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>59</th>
   <td><pre>  <span class="n">arduinoBoard</span> <span class="o">=</span> <span class="k">new</span> <span class="n">arduinoWindow</span><span class="p">(</span><span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">uiController</span><span class="p">()</span><span class="o">-></span><span class="n">activeMainWindow</span><span class="p">());</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">memory leak</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line39" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>39</th>
   <td><pre>  <span class="n">downloadStatusLabel</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="s">""</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">->clear();</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line40" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>40</th>
   <td><pre>  <span class="n">installStatusLabel</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="s">""</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">->clear();</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line34" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>34</th>
   <td><pre>  <span class="n">downloadFinished</span><span class="o">=</span><span class="n">installFinished</span><span class="o">=</span><span class="nb">false</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">initialize in the initializer list.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line35" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>35</th>
   <td><pre>  <span class="n">mDownloadManager</span> <span class="o">=</span> <span class="k">new</span> <span class="n">QNetworkAccessManager</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initialize in the initializer list, also, memleak - you never free mDownloadManager.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line115" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>115</th>
   <td><pre>  <span class="n">QTemporaryFile</span> <span class="nf">archive</span><span class="p">(</span><span class="s">"arduino"</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use a random generated name.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line128" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>128</th>
   <td><pre>      <span class="k">static</span> <span class="k">const</span> <span class="kt">int</span> <span class="n">bufferSize</span> <span class="o">=</span> <span class="mi">8192</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">magic number: create a constant for it and add a comment on what this is.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line141" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>141</th>
   <td><pre>      <span class="n">QStringList</span> <span class="n">extractArgs</span> <span class="o">=</span> <span class="n">QStringList</span><span class="p">();</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QStringList extractArgs;</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line149" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>149</th>
   <td><pre>      <span class="n">QFuture</span><span class="o"><</span><span class="kt">int</span><span class="o">></span> <span class="n">extractFuture</span> <span class="o">=</span> <span class="n">QtConcurrent</span><span class="o">::</span><span class="n">run</span><span class="p">(</span><span class="o">&</span><span class="n">QProcess</span><span class="o">::</span><span class="n">execute</span><span class="p">,</span> <span class="n">extractCommand</span><span class="p">,</span> <span class="n">extractArgs</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't call a extrenal program to extract a file, use KArchive.</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line176" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>176</th>
   <td><pre>  <span class="n">defaultArduinoPaths</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">static initialize it:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">static QStringList defaultArduinoPath = { strings here };</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line185" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>185</th>
   <td><pre>  <span class="c1">//change to ->caontins ?</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">caontins?</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line211" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>211</th>
   <td><pre>  <span class="k">return</span> <span class="s">""</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">return QString();</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2963/#source/line216" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.cpp</a>

   <p>firsttimewizard.cpp</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>216</th>
   <td><pre>  <span class="k">return</span> <span class="s">""</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">return QString();</p></pre>
</div>
<br />

<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
 <tr>
  <td>
   <a href="https://git.reviewboard.kde.org/r/127749/file/2964/#source/line22" style="color: black; font-weight: bold; font-size: 9pt;">firsttimewizard.h</a>

   <p>firsttimewizard.h</p>



    <div>



<table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
 <colgroup>

  <col class="line" />
  <col class="right" />
 </colgroup>

 <tbody>

  <tr>
   <th>22</th>
   <td><pre>  <span class="n">QSettings</span> <span class="o">*</span><span class="n">settings</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>
</div>


  </td>
 </tr>
</table>
<div style="margin-left: 2em;">

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you don't use settings like this, they should be created on the stack, not on the heap.</p></pre>
</div>
<br />





<p>- Tomaz  Canabrava</p>


<br />
<p>On April 26th, 2016, 3:05 a.m. UTC, patrick pereira wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop, Sven Brauch, Kevin Funk, and Tomaz  Canabrava.</div>
<div>By patrick pereira.</div>


<p style="color: grey;"><i>Updated April 26, 2016, 3:05 a.m.</i></p>










<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Embedded plugin for KDevelop</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Review of embedded plugin for KDevelop
Plugin created to help the development of embedded systems.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">.
|-- CMakeLists.txt
|-- README.md
|-- arduinowindow.cpp
|-- arduinowindow.h
|-- arduinowindow.ui
|-- boardsimg
|   |-- ATmega644c3.svg
|   |-- ATtiny85_breadboard.svg
|   |-- Adafruit_Atmega32u4_Breakout.svg
|   |-- ArduPilotMega_v15_breadboard.svg
|   |-- Arduino\ Nano3_breadboard.svg
|   |-- Arduino\ Voice\ Shield-v16_breadboard.svg
|   |-- Arduino-BLE-LowPower-RevB-final_5_breadboard.svg
|   |-- Arduino-Ethernet-v11_breadboard.svg
|   |-- Arduino-Fio-v22_breadboard.svg
|   |-- Arduino-Mini-v5_breadboard.svg
|   |-- Arduino-Pro-Mini-v13_breadboard.svg
|   |-- ArduinoBluetoothMatev13_breadboard.svg
|   |-- Arduino_ADK_MEGA_2560-Rev3_breadboard.svg
|   |-- Arduino_DUE_V02b_breadboard.svg
|   |-- Arduino_Esplora_breadboard.svg
|   |-- Arduino_Ethernet_breadboard.svg
|   |-- Arduino_Leonardo_Rev3_breadboard.svg
|   |-- Arduino_MEGA_2560-Rev3_breadboard.svg
|   |-- Arduino_Micro_Rev03_breadboard.svg
|   |-- Arduino_Pro_breadboard.svg
|   |-- Arduino_bt07_breadboard.svg
|   |-- Ardumoto\ v13_breadboard.svg
|   |-- LICENSE.CC-BY-SA
|   |-- NetduinoPlus2.svg
|   |-- README.md
|   |-- TI_Launchpad_MSP430G2.1_breadboard.svg
|   |-- TI_Launchpad_MSP430G2_breadboard.svg
|   |-- Teensy_2.0_++_breadboard.svg
|   |-- Teensy_2.0_breadboard.svg
|   |-- Teensy_3.0+pads_breadboard.svg
|   |-- Teensy_3.0_breadboard.svg
|   |-- Udoo_dual_breadboard.svg
|   |-- Wiring_Sa99.svg
|   |-- arduino_Uno_Rev3_breadboard-old.svg
|   |-- arduino_Uno_Rev3_breadboard.svg
|   |-- arduino_Yun(rev1)_breadboard.svg
|   |-- arduino_mini_usb_adapter.svg
|   |-- arduino_uno(rev3)-icsp_breadboard.svg
|   |-- atlas-sientific_Conductivity\ Circuit_breadboard.svg
|   |-- atlas-sientific_D.O.\ Circuit_breadboard.svg
|   |-- intel-arduino-galileo_breadboard.svg
|   |-- intel-arduino-galileo_gen2_breadboard.svg
|   <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-- intel_edison-hirosedf40_breadboard.svg
|-- doc_templates
|   |-- CMakeLists.txt
|   |-- doxygen_cpp.txt
|   |-- phpdoc_php.txt
|</code>-- rest_python.txt
|-- embedded.cpp
|-- embedded.h
|-- embeddedproject
|   |-- %{APPNAMELC}.cpp
|   |-- %{APPNAMELC}.h
|   |-- %{PROJECTDIRNAME}.kdev4
|   |-- Makefile
|   |-- embeddedproject.kdevtemplate
|   |-- main.cpp
|   <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-- options.kcfg
|-- firsttimewizard.cpp
|-- firsttimewizard.h
|-- firsttimewizard.ui
|-- kdevembedded.json
|-- kdevembedded.qrc
|-- kdevembedded.rc
|-- patrick.kdev4
|-- toolkit.cpp</code>-- toolkit.h</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127749/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/a8f69b53-9658-4552-8345-16a2f236fed8__CMakeLists.txt">CMakeLists.txt</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/9d614ff1-c625-40b1-8a26-3ca3c6396a6f__README.md">README.md</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6e95cc7f-a880-471f-8300-67c7584ef6fa__arduinowindow.cpp">arduinowindow.cpp</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/29f98560-4081-4820-bc4b-cf0acba65f55__arduinowindow.h">arduinowindow.h</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/14591880-85df-45f7-b192-9059ef1a5a90__embedded.cpp">embedded.cpp</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/3720a34d-40ff-45ad-853c-eb5955bc4287__embedded.h">embedded.h</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/51f2f2ed-605c-49b1-87b7-85f6447c8274__firsttimewizard.cpp">firsttimewizard.cpp</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/6171895d-b2ed-4f7d-85e8-c01dd511b17e__firsttimewizard.h">firsttimewizard.h</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/df4ccf03-fce7-43f5-be0e-11e00680ea12__kdevembedded.json">kdevembedded.json</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/82f7d7ad-7e02-433c-aaa5-07fea7a8f66e__kdevembedded.qrc">kdevembedded.qrc</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8f3d5a6d-bb86-48c9-84e7-cd5affcd750b__kdevembedded.rc">kdevembedded.rc</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/eb8ac57a-2b8c-4ba1-93d5-45e6be9d56f2__toolkit.cpp">toolkit.cpp</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/88fa0dc5-af42-418a-84f8-6c1d35502c68__toolkit.h">toolkit.h</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/26/8d22467a-6f78-4c38-92af-c08438c2db13__README.md">README.md</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>