<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127152/">https://git.reviewboard.kde.org/r/127152/</a>
     </td>
    </tr>
   </table>
   <br />



<p>

Fix it, then Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM</p></pre>
 <br />







<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/127152/diff/1/?file=445074#file445074line62" style="color: black; font-weight: bold; text-decoration: underline;">documentation/qthelp/qthelpqtdoc.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="n">p</span><span class="o">-></span><span class="n">setArguments</span><span class="p">(</span><span class="n">QStringList</span><span class="p">(</span><span class="s">"-query"</span><span class="p">)</span> <span class="o"><<</span> <span class="s">"QT_INSTALL_DOCS"</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now that you touch it...
{"-query", "QT_INSTALL_DOCS"}</p></pre>
 </div>
</div>
<br />



<p>- Aleix Pol Gonzalez</p>


<br />
<p>On February 22nd, 2016, 9:59 p.m. CET, Laurent Navet wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Laurent Navet.</div>


<p style="color: grey;"><i>Updated Feb. 22, 2016, 9:59 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">replace KProcess by QProcess where it doesn't overbloat the code</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build and run</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>documentation/qthelp/qthelpqtdoc.cpp <span style="color: grey">(817da64)</span></li>

 <li>kdeintegration/executeplasmoid/plasmoidexecutionjob.h <span style="color: grey">(b862ff4)</span></li>

 <li>projectbuilders/cmakebuilder/cmakebuilder.cpp <span style="color: grey">(197abf1)</span></li>

 <li>projectbuilders/ninjabuilder/ninjajob.h <span style="color: grey">(22c821f)</span></li>

 <li>projectbuilders/ninjabuilder/ninjajob.cpp <span style="color: grey">(e46e1ea)</span></li>

 <li>projectmanagers/cmake/cmakebuilddirchooser.cpp <span style="color: grey">(febe173)</span></li>

 <li>projectmanagers/cmake/parser/cmakeprojectvisitor.cpp <span style="color: grey">(8f4df9d)</span></li>

 <li>projectmanagers/cmake/testing/ctestfindjob.h <span style="color: grey">(5ab4c7a)</span></li>

 <li>projectmanagers/cmake/testing/ctestfindjob.cpp <span style="color: grey">(7bac3cc)</span></li>

 <li>projectmanagers/cmake/testing/ctestrunjob.h <span style="color: grey">(2618a93)</span></li>

 <li>projectmanagers/cmake/testing/ctestrunjob.cpp <span style="color: grey">(4145592)</span></li>

 <li>projectmanagers/cmake/testing/ctestsuite.cpp <span style="color: grey">(66a96db)</span></li>

 <li>projectmanagers/cmake/tests/cmakecompliance.cpp <span style="color: grey">(20b6f9d)</span></li>

 <li>projectmanagers/custom-buildsystem/custombuildjob.cpp <span style="color: grey">(64d208a)</span></li>

 <li>projectmanagers/qmake/qmakejob.h <span style="color: grey">(0c2a332)</span></li>

 <li>projectmanagers/qmake/qmakejob.cpp <span style="color: grey">(acc8c05)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127152/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>