<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126763/">https://git.reviewboard.kde.org/r/126763/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Vavelin Kevin and Olivier de Gaalon.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2016, 1:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently the completion list opens whenever there's assistants available. That is way too agressive (e.g. when just moving the cursor somewhere, the completion list opens). Also you can barely type a line (or even character) without creating a problem, with an associated clang fixit, which invokes completion. This patch attempts to tackle these problems with two changes:
- assistant actions now have a flag telling whether they should be shown automatically. This is only set to "on" for the rename assistant currently. Other assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space).
- problem-associated assistants are only shown when the revision they are associated with matches the current document revision. This avoids showing assistants while the user is typing (e.g. "add semicolon" when the user has in fact already typed the semicolon).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Used it for a while. I find kdevelop significiantly more pleasant to use with those changes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iassistant.h <span style="color: grey">(3f93d52)</span></li>
<li>interfaces/iassistant.cpp <span style="color: grey">(b606022)</span></li>
<li>language/assistant/assistantcompletionmodel.h <span style="color: grey">(4a6836a)</span></li>
<li>language/assistant/assistantcompletionmodel.cpp <span style="color: grey">(78bd544)</span></li>
<li>language/assistant/renameassistant.cpp <span style="color: grey">(62f58a0)</span></li>
<li>language/assistant/staticassistantsmanager.cpp <span style="color: grey">(92ca321)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>