<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126663/">https://git.reviewboard.kde.org/r/126663/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Январь 7th, 2016, 4:06 п.п. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Sergey, have you checked that the tests run?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, just ran tests - 8 failed, same on current master. So that's not my bad, I think.</p></pre>
<br />
<p>- Sergey</p>
<br />
<p>On Январь 7th, 2016, 4:02 п.п. UTC, Sergey Popov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Sergey Popov.</div>
<p style="color: grey;"><i>Updated Янв. 7, 2016, 4:02 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix most Clazy warnings in shell/ and sublime/ subdirectories in KDevPlatform.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are two "missing Q_OBJECT macro" warnings, which I couldn't fix:
- shell/workingsets/workingsettooltipwidget.h:55:5 - KDevelop::WorkingSetToolTipWidget::FileWidget class
- shell/settings/sessionconfigskeleton.h:32:1 - KDevelop::SessionConfigSkeleton class</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related GCI-2015 task: https://codein.withgoogle.com/tasks/5743715154919424/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sucessfully built</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/completionsettings.h <span style="color: grey">(05f166b)</span></li>
<li>shell/areadisplay.cpp <span style="color: grey">(7699c32)</span></li>
<li>shell/completionsettings.cpp <span style="color: grey">(89cf68b)</span></li>
<li>shell/configdialog.cpp <span style="color: grey">(cd292ef)</span></li>
<li>shell/core.cpp <span style="color: grey">(640079c)</span></li>
<li>shell/debugcontroller.cpp <span style="color: grey">(520a356)</span></li>
<li>shell/documentationcontroller.cpp <span style="color: grey">(c517fa7)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(3d83376)</span></li>
<li>shell/editorconfigpage.cpp <span style="color: grey">(34f4c1c)</span></li>
<li>shell/environmentconfigurebutton.cpp <span style="color: grey">(fcb988f)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(9a77d42)</span></li>
<li>shell/launchconfigurationdialog.h <span style="color: grey">(8a1ebfb)</span></li>
<li>shell/launchconfigurationdialog.cpp <span style="color: grey">(dccc7cd)</span></li>
<li>shell/loadedpluginsdialog.cpp <span style="color: grey">(4b343cd)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(571bfba)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(ac3d471)</span></li>
<li>shell/openprojectdialog.cpp <span style="color: grey">(7922234)</span></li>
<li>shell/openprojectpage.cpp <span style="color: grey">(9d1a050)</span></li>
<li>shell/partcontroller.cpp <span style="color: grey">(332fc4a)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(01c1c9a)</span></li>
<li>shell/progresswidget/progressdialog.cpp <span style="color: grey">(2cda081)</span></li>
<li>shell/progresswidget/statusbarprogresswidget.cpp <span style="color: grey">(46f56e9)</span></li>
<li>shell/project.cpp <span style="color: grey">(a7880c1)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(766c280)</span></li>
<li>shell/projectinfopage.cpp <span style="color: grey">(3641ac9)</span></li>
<li>shell/projectsourcepage.cpp <span style="color: grey">(100a5d7)</span></li>
<li>shell/runcontroller.cpp <span style="color: grey">(0487fbe)</span></li>
<li>shell/session.cpp <span style="color: grey">(0cc9a0d)</span></li>
<li>shell/sessionchooserdialog.cpp <span style="color: grey">(10c7872)</span></li>
<li>shell/sessioncontroller.cpp <span style="color: grey">(58433de)</span></li>
<li>shell/sessiondialog.cpp <span style="color: grey">(1e17290)</span></li>
<li>shell/sessionlock.cpp <span style="color: grey">(2113c1c)</span></li>
<li>shell/settings/editstyledialog.cpp <span style="color: grey">(ecb2240)</span></li>
<li>shell/settings/environmentwidget.cpp <span style="color: grey">(9002685)</span></li>
<li>shell/settings/pluginpreferences.h <span style="color: grey">(b2e4971)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(cc61a54)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(161e2ed)</span></li>
<li>shell/settings/templateconfig.cpp <span style="color: grey">(396ea68)</span></li>
<li>shell/settings/templatepage.cpp <span style="color: grey">(9c5d8e0)</span></li>
<li>shell/settings/uipreferences.h <span style="color: grey">(e813051)</span></li>
<li>shell/sourceformattercontroller.h <span style="color: grey">(c47fd5f)</span></li>
<li>shell/sourceformattercontroller.cpp <span style="color: grey">(ecd6abd)</span></li>
<li>shell/statusbar.cpp <span style="color: grey">(96563f8)</span></li>
<li>shell/tests/nonguiinterfaceplugin.cpp <span style="color: grey">(0051be5)</span></li>
<li>shell/tests/test_detectedproblem.cpp <span style="color: grey">(114776f)</span></li>
<li>shell/tests/test_documentcontroller.cpp <span style="color: grey">(b0e75d6)</span></li>
<li>shell/tests/test_ktexteditorpluginintegration.cpp <span style="color: grey">(b2c2ba0)</span></li>
<li>shell/tests/test_plugincontroller.cpp <span style="color: grey">(b847e50)</span></li>
<li>shell/tests/test_projectcontroller.cpp <span style="color: grey">(cdb9ba5)</span></li>
<li>shell/tests/test_sessioncontroller.cpp <span style="color: grey">(01cb4b5)</span></li>
<li>shell/tests/test_shellbuddy.cpp <span style="color: grey">(3b87189)</span></li>
<li>shell/tests/test_shelldocumentoperation.cpp <span style="color: grey">(6718ef3)</span></li>
<li>shell/tests/test_testcontroller.cpp <span style="color: grey">(1e5e101)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(501b592)</span></li>
<li>shell/uicontroller.h <span style="color: grey">(88e3da9)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(44f35bd)</span></li>
<li>shell/workingsetcontroller.cpp <span style="color: grey">(759816a)</span></li>
<li>shell/workingsets/closedworkingsetswidget.cpp <span style="color: grey">(6c2b4c7)</span></li>
<li>shell/workingsets/workingset.cpp <span style="color: grey">(0110d05)</span></li>
<li>shell/workingsets/workingsettoolbutton.cpp <span style="color: grey">(96c3454)</span></li>
<li>shell/workingsets/workingsettooltipwidget.cpp <span style="color: grey">(696eca5)</span></li>
<li>sublime/area.cpp <span style="color: grey">(0ba14af)</span></li>
<li>sublime/areaindex.cpp <span style="color: grey">(f9d585a)</span></li>
<li>sublime/container.cpp <span style="color: grey">(9e088bc)</span></li>
<li>sublime/examples/example1main.cpp <span style="color: grey">(1dfcf6e)</span></li>
<li>sublime/examples/example2.cpp <span style="color: grey">(1602c9d)</span></li>
<li>sublime/examples/example2main.cpp <span style="color: grey">(d917daf)</span></li>
<li>sublime/idealcontroller.cpp <span style="color: grey">(9ddb18b)</span></li>
<li>sublime/idealdockwidget.cpp <span style="color: grey">(7ea81e3)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(309db08)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(32d9038)</span></li>
<li>sublime/tests/areaprinter.cpp <span style="color: grey">(5cb6255)</span></li>
<li>sublime/tests/test_aggregatemodel.cpp <span style="color: grey">(20fc6d8)</span></li>
<li>sublime/tests/test_areaoperation.cpp <span style="color: grey">(8a9c1a8)</span></li>
<li>sublime/tests/test_areawalker.cpp <span style="color: grey">(7c31598)</span></li>
<li>sublime/tests/test_controller.cpp <span style="color: grey">(485a858)</span></li>
<li>sublime/tests/test_document.cpp <span style="color: grey">(8139fc3)</span></li>
<li>sublime/tests/test_toolviewtoolbar.cpp <span style="color: grey">(837a760)</span></li>
<li>sublime/tests/test_view.cpp <span style="color: grey">(34479d5)</span></li>
<li>sublime/tests/test_viewactivation.cpp <span style="color: grey">(ac50d95)</span></li>
<li>sublime/tooldocument.h <span style="color: grey">(50014a4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126663/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>