<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124833/">https://git.reviewboard.kde.org/r/124833/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Maciej Poleski.</div>
<p style="color: grey;"><i>Updated Sie 24, 2015, 3:31 rano</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Introduce <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">UsrComparator</code> - I finally found something I was looking for for months: declaration name mangler used by Clang Unified Symbol Resolution. Introduced <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">UsrComparator</code> which uses <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">clang::index::generateUSRForDecl</code> to get mangled name and compares declarations by mangled name. It will improve everything and can deprecate <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">DeclarationSymbol</code>.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Improve type inference in Change Signature refactoring (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">toString(QualType)</code>)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Fix (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Decl</code> pointer -> <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">LexicalLocation</code>) and improve TUDeclDispatcher (half of day spent on this: http://clang.llvm.org/doxygen/ExprCXX_8cpp_source.html#l00547)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">improve type inference everywhere</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">clean up dependencies is CMakeLists.txt</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">ignore implicit casts in encapsulate field refactoring (like derived to base)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">fix move function (place function definition only in record definition)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">workaround issues in deduplication code in DocumentChangeSet</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>refactoring/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/changesignaturerefactoring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/changesignaturerefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/changesignaturerefactoringinfopack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/changesignaturerefactoringinfopack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/contextmenumutator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/documentcache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/documentcache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/encapsulatefieldrefactoring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/encapsulatefieldrefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/encapsulatefieldrefactoring_changepack.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/encapsulatefieldrefactoring_changepack.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/extractfunctionrefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/extractvariablerefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/instancetostaticrefactoring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/instancetostaticrefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/movefunctionrefactoring.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/movefunctionrefactoring.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/tudecldispatcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/tudecldispatcher.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/usrcomparator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/usrcomparator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124833/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>