<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124793/">https://git.reviewboard.kde.org/r/124793/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Aleix Pol Gonzalez</p>


<br />
<p>On August 17th, 2015, 6:23 p.m. CEST, Kevin Funk wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.</div>
<div>By Kevin Funk.</div>


<p style="color: grey;"><i>Updated Aug. 17, 2015, 6:23 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(SNIP: History since SVN times)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Imported kdev-qmake as subtree</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initial integration of the QMake plugin</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We now depend on kdevelop-pg-qt</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(1ce433e6ee6e5bea919534c440fbd56acb7c2bf6)</span></li>

 <li>qmakeintegration/.gitignore <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/.kateconfig <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/CTestConfig.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/CTestCustom.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/TODO <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/cpp/QMake/qmake_qt4guiapp/%{PROJECTDIRNAME}.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/cpp/QMake/qmake_qt4guiapp/%{PROJECTDIRNAME}.pro <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/cpp/QMake/qmake_qt4guiapp/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/cpp/QMake/qmake_qt4guiapp/mainwindow.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/app_templates/cpp/QMake/qmake_qt4guiapp/qmake_qt4guiapp.kdevtemplate <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/debug.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/kdev-qmake.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/kdevqmakemanager.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/.krazy <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/ast.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/buildastvisitor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/buildastvisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmake.g <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakeast.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakeastdefaultvisitor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakeastdefaultvisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakeastvisitor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakeastvisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakedebugvisitor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakedebugvisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakedriver.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakedriver.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakelexer.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/qmakelexer.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/assignmenttest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/assignmenttest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/functionscopetest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/functionscopetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/lexertest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/lexertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/parsetest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/parsetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/scopetest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/scopetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/testhelpers.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/parser/tests/testhelpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmake.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilddirchooser.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilddirchooser.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilddirchooser.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilddirchooserdialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilddirchooserdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/data.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/iqmakebuilder.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/kdevqmakebuilder.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilder.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilder.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderconfig.kcfg <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderconfig.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderdebug.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderdebug.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderpreferences.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakebuilderpreferences.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakeconfig.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakejob.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakebuilder/qmakejob.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakecache.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeconfig.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakefile.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakefile.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakefilevisitor.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakefilevisitor.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeincludefile.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeincludefile.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakejob.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakejob.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemanager.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemkspecs.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemkspecs.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemodelitems.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakemodelitems.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeprojectfile.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/qmakeprojectfile.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/basic_project/.kdev4/basic_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/basic_project/basic_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/basic_project/basic_project.pro <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/basic_project/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/basic_project/mainwindow.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/.kdev4/subdirs_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/dir_a/dir_a.pro <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/dir_a/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/dir_b/dir_b.pro <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/dir_b/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/subdirs_project.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/manual/subdirs_project/subdirs_project.pro <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/qmaketestconfig.h.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/test_qmakefile.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/test_qmakefile.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/test_qmakeproject.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/tests/test_qmakeproject.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/variablereferenceparser.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>qmakeintegration/variablereferenceparser.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124793/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>