<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122874/">https://git.reviewboard.kde.org/r/122874/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Alex Richardson and Milian Wolff.</div>
<div>By Guy Maurel.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2015, 5:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">9. 3. 2015
As a newcomer I don't set all the environment variables I should have set!
This gives me the opportunity to check the error messages I might get.
So happens to me as I start kdevelop.
I get a window but it doesn't really work.
I just get the error message:
Can't load plugin "KDevXyz123" because a factory to load the plugin could not be obtained: "The shared library was not found."
This is for a newcomer as I too little help.
1.
My proposal generates a longer message such as:
Can't load plugin "KDevXyz123" "The shared library was not found."
Plugin search paths are ("/usr/lib/qt/plugins", "/usr/local/bin", "/home/guy-kde/.kde/lib/kde4/plugins", "/usr/lib/kde4/plugins")
The environment variable QT_PLUGIN_PATH might be not correctly set
And some more...
2.
I put this before the line:
auto factory = loader.factory();
because it is not wise to look for a factory if the loader is not correct.
3.
The method PluginController::loadPluginInternal( const QString &pluginId )
returns a IPlugin *, which might be nullptr.
Some of the calls of this method take care of the return value, some others not.
Should it be wise to care care at every calls?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/plugincontroller.cpp <span style="color: grey">(362bfb07cea3ae10921027a6f41f4d47913eed7c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122874/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>