<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124779/">https://git.reviewboard.kde.org/r/124779/</a>
     </td>
    </tr>
   </table>
   <br />











<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/124779/diff/1/?file=395248#file395248line167" style="color: black; font-weight: bold; text-decoration: underline;">shell/tests/test_detectedproblem.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">167</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">QCOMPARE</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span class="n">m_problem</span><span class="o">-></span><span class="n">diagnostics</span><span class="p">().</span><span class="n">size</span><span class="p">());</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">actual/expected switched. Should be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QCOMPARE(actual, expected)</code>. Lots of repetitions, please fix.</p></pre>
 </div>
</div>
<br />



<p>- Kevin Funk</p>


<br />
<p>On August 16th, 2015, 6:22 p.m. UTC, Laszlo Kis-Adam wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Laszlo Kis-Adam.</div>


<p style="color: grey;"><i>Updated Aug. 16, 2015, 6:22 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests for the following classes:
* DetectedProblem
* ProblemStoreNode
* ProblemStore
* FilteredProblemStore
* ProblemModel
* ProblemModelSet
* ProblemsView</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/problemreporter/CMakeLists.txt <span style="color: grey">(e179232)</span></li>

 <li>plugins/problemreporter/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plugins/problemreporter/tests/test_problemsview.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/filteredproblemstore.h <span style="color: grey">(d6cc909)</span></li>

 <li>shell/filteredproblemstore.cpp <span style="color: grey">(a27b9ac)</span></li>

 <li>shell/problemstore.h <span style="color: grey">(97f34f3)</span></li>

 <li>shell/problemstore.cpp <span style="color: grey">(4b114b2)</span></li>

 <li>shell/tests/CMakeLists.txt <span style="color: grey">(6b18470)</span></li>

 <li>shell/tests/test_detectedproblem.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/tests/test_filteredproblemstore.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/tests/test_problemmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/tests/test_problemmodelset.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/tests/test_problemstore.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>shell/tests/test_problemstorenode.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124779/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>