<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124539/">https://git.reviewboard.kde.org/r/124539/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 31st, 2015, 6:50 a.m. UTC, <b>Olivier Jean de Gaalon</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Typically it's considered "good form" (by people who write things of such beauty), to use SFINAE:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">template</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">bool</span> <span style="color: #008000; font-weight: bold">B</span><span style="color: #666666">></span>
<span style="color: #008000; font-weight: bold">using</span> <span style="color: #008000; font-weight: bold">KDevHashType</span> <span style="color: #666666">=</span> <span style="color: #008000; font-weight: bold">typename</span> <span style="color: #008000; font-weight: bold">std</span><span style="color: #666666">:</span><span style="color: #AA22FF">:enable_if</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">B</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">KDevHash</span><span style="color: #666666">&>:</span><span style="color: #AA22FF">:type</span><span style="color: #666666">;</span>
<span style="color: #008000; font-weight: bold">template</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">typename</span> <span style="color: #008000; font-weight: bold">Integer</span><span style="color: #666666">></span>
<span style="color: #008000; font-weight: bold">KDevHashType</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">std</span><span style="color: #666666">:</span><span style="color: #AA22FF">:is_integral</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">Integer</span><span style="color: #666666">>:</span><span style="color: #AA22FF">:value</span><span style="color: #666666">></span> <span style="color: #008000; font-weight: bold">operator</span><span style="color: #666666"><<(</span><span style="color: #008000; font-weight: bold">Integer</span> <span style="color: #008000; font-weight: bold">value</span><span style="color: #666666">)</span> { <span style="color: #666666">...</span> }
<span style="color: #008000; font-weight: bold">template</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">typename</span> <span style="color: #008000; font-weight: bold">T</span><span style="color: #666666">></span>
<span style="color: #008000; font-weight: bold">KDevHashType</span><span style="color: #666666"><!</span><span style="color: #008000; font-weight: bold">std</span><span style="color: #666666">:</span><span style="color: #AA22FF">:is_integral</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">T</span><span style="color: #666666">>:</span><span style="color: #AA22FF">:value</span><span style="color: #666666">></span> <span style="color: #008000; font-weight: bold">operator</span><span style="color: #666666"><<(</span><span style="color: #008000; font-weight: bold">T</span> <span style="color: #008000; font-weight: bold">value</span><span style="color: #666666">)</span> { <span style="color: #666666">...</span> }
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This would also make it simpler to add additional type overloads in the future.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But I'd also understand if you just want to ignore the guy responsible for the mess that is TUDUChain :).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I actually tried it, but couldn't make it work. Your code above looks good, I'll take that :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">thanks!</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On July 30th, 2015, 10:04 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated July 30, 2015, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Optimize KDevHash for integral types.
For integral types, we now reuse qHash internally and only
fall back to the O(sizeof(T)) implementation for other
types.
Before:
********* Start testing of TestKDevHash *********
Config: Using QtTest library 5.5.0, Qt 5.5.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.1.0)
PASS : TestKDevHash::initTestCase()
PASS : TestKDevHash::benchHash_int()
RESULT : TestKDevHash::benchHash_int():
0.075 msecs per iteration (total: 77, iterations: 1024)
PASS : TestKDevHash::benchHash_uint()
RESULT : TestKDevHash::benchHash_uint():
0.075 msecs per iteration (total: 77, iterations: 1024)
PASS : TestKDevHash::benchHash_quint64()
RESULT : TestKDevHash::benchHash_quint64():
0.15 msecs per iteration (total: 77, iterations: 512)
PASS : TestKDevHash::benchHash_bool()
RESULT : TestKDevHash::benchHash_bool():
0.018 msecs per iteration (total: 77, iterations: 4096)
PASS : TestKDevHash::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of TestKDevHash *********
After:
********* Start testing of TestKDevHash *********
Config: Using QtTest library 5.5.0, Qt 5.5.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.1.0)
PASS : TestKDevHash::initTestCase()
PASS : TestKDevHash::benchHash_int()
RESULT : TestKDevHash::benchHash_int():
0.024 msecs per iteration (total: 51, iterations: 2048)
PASS : TestKDevHash::benchHash_uint()
RESULT : TestKDevHash::benchHash_uint():
0.024 msecs per iteration (total: 51, iterations: 2048)
PASS : TestKDevHash::benchHash_quint64()
RESULT : TestKDevHash::benchHash_quint64():
0.026 msecs per iteration (total: 54, iterations: 2048)
PASS : TestKDevHash::benchHash_bool()
RESULT : TestKDevHash::benchHash_bool():
0.022 msecs per iteration (total: 92, iterations: 4096)
PASS : TestKDevHash::cleanupTestCase()
Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of TestKDevHash *********</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/CMakeLists.txt <span style="color: grey">(2c2b0285b68d209e07af185c43dcf157507f5a54)</span></li>
<li>language/util/kdevhash.h <span style="color: grey">(40c32935aec9c7e5552769e780c033e96cf63166)</span></li>
<li>language/util/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>language/util/tests/test_kdevhash.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectfilter/projectfilter.h <span style="color: grey">(014e5a1eabbb3a2d9e71baeee3e38643cb8649e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124539/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>