<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124426/">https://git.reviewboard.kde.org/r/124426/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Puh, Maciej, lets do it - but this is extremely complex code. As I said before, I'd welcome if we could discuss the future of your GSOC. In my opinion, this is the wrong direction, and we should try to take a step back and see how we could get something more useful - albeit far simpler - out of the clang integration. Don't get me wrong, your contributions are all extremely valuable. It just looks to me as if libTooling is not a good match for integration into KDevelop in the current form.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I said before, I'd like to see how we could implement "simple" local refactorings - probably without libTooling and just using the clang-c API. You could start with things like a de-inliner, i.e. similar to what we have in oldcpp (the "move to source" action).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let's discuss this on our mailing list more, or better yet on IRC if possible. I'll continue to review your other patches now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cheers</p></pre>
<br />
<p>- Milian Wolff</p>
<br />
<p>On July 27th, 2015, 7:43 p.m. UTC, Maciej Poleski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Maciej Poleski.</div>
<p style="color: grey;"><i>Updated July 27, 2015, 7:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Introduced worker thread for time-consuming Clang actions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Moved populating of context menu (list of applicable refactorings) to background.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual testing</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>refactoring/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/actionwatcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/actionwatcher.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/contextmenumutator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/contextmenumutator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/kdevrefactorings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/kdevrefactorings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringcontext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringcontext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringcontext_worker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringcontext_worker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>refactoring/refactoringmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>