<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124427/">https://git.reviewboard.kde.org/r/124427/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 24th, 2015, 9:16 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">LGTM, but what did you mean by "these changes break code with std::move" - can you please clarifiy?</p></pre>
</blockquote>
<p>On July 24th, 2015, 9:30 a.m. UTC, <b>Boris Egorov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tests fail to pass. I removed failing lines, you can see them in diff. They are working with 'moved-from' objects. For example, test them for emptiness.</p></pre>
</blockquote>
<p>On July 24th, 2015, 9:41 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, I just looked at the diff in more depth (it was too long, sorry for my tl;dr; fail!)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How did the change to add explicit ctors fail these tests? Do you know? I would assume it should be unrelated? Also, some parts of these tests I added deliberately afaik. And testing for emptiness of an moved-from object sounds perfectly fine to me. Why did you remove that?</p></pre>
</blockquote>
<p>On July 24th, 2015, 9:49 a.m. UTC, <b>Boris Egorov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know how exactly my changes broke tests. But I ran them before and after changes, and they definitely started failing after.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Like I said in commit message, I read in some[1] resources[2] that move-from object remains in valid, but not unspecified state. So we can delete them or assign to them, but we should not do any assumptions about their state or contents. Moved strings can be not empty, for example (I saw exactly this behaviour in failed tests).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can be wrong, I haven't worked with std::move much.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">1:</span> http<span style="color: #666666">://</span>en<span style="color: #666666">.</span><span style="color: #7D9029">cppreference</span><span style="color: #666666">.</span><span style="color: #7D9029">com</span><span style="color: #BB6688">/w/cpp/utility/</span>move
<span style="color: #666666">2:</span> http<span style="color: #666666">://</span>stackoverflow<span style="color: #666666">.</span><span style="color: #7D9029">com</span><span style="color: #BB6688">/questions/20850196/what-lasts-after-using-stdmove-c11/</span><span style="color: #666666">20850223</span><span style="border: 1px solid #FF0000">#</span><span style="color: #666666">20850223</span>
</pre></div>
</p></pre>
</blockquote>
<p>On July 24th, 2015, 9:51 a.m. UTC, <b>Boris Egorov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"move-from object remains in valid, but not unspecified state" => "moved-from objects remain in valid, but unspecified state"</p></pre>
</blockquote>
<p>On July 24th, 2015, 10:17 a.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We implement the move semantics, well - I did. And I wanted to explictily keep them in a somewhat sane state afterwards. Moving from it means an item becomes invalid/empty. Thus calling <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QVERIFY(movedFrom.isEmpty())</code> should still work. If not, then there is an issue which we <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">must</em> debug. I would actually say please revert that part of this patch, and also the corresponding "explicit" ctors that trigger the tests failures. Then we can discuss on the ML together why this happens. In general, disabling tests in such a way is seldom a good idea, <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">especially</em> if you are not sure why they suddenly break.</p></pre>
</blockquote>
<p>On July 24th, 2015, 10:24 a.m. UTC, <b>Boris Egorov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, I didn't know that and assumed it was some kind of redundant test. I'm sorry. We are lucky you spotted these changes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I haven't detected the exact ctors triggering failures, but I'll try to find them and revert them today. Most likely candidates are Identifier and IndexedString whose tests fail.</p></pre>
</blockquote>
<p>On July 24th, 2015, 10:30 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Milian: Sorry, I didn't notice the hunks in those .cpp files either. For some reason Reviewboard was showing only parts of the patch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Indeed, disabling/removing those lines from the tests is a bad idea.</p></pre>
</blockquote>
<p>On July 24th, 2015, 10:44 a.m. UTC, <b>Boris Egorov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should I create a new review request, or would it be better to reopen this one?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tried to revert IndexedString ctord - yeah, one test was failing due to this change. Rebuilding project with reverted Identifier ctors now.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Boris: Open a new one, where you restore the removed lines in the tests, and where the tests actually succeed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On July 23rd, 2015, 9:38 a.m. UTC, Boris Egorov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Boris Egorov.</div>
<p style="color: grey;"><i>Updated July 23, 2015, 9:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some constructors cannot be made explicit without further code
modifications (project fails to build). Examples:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">IndexedDeclaration
IndexedQualifiedIdentifier
ReferencedTopDUContext
IndexedDUContext
IndexedTopDUContext
LocalIndexedDeclaration
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Somehow these changes break tests with std::move. Some sources said
that "moved-from" variables is in unspecified state after moving, so
let's disable assertions working with such variables.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, passes tests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/breakpoint/breakpointdetails.h <span style="color: grey">(dff8cf2)</span></li>
<li>debugger/breakpoint/breakpointmodel.h <span style="color: grey">(c12e8fa)</span></li>
<li>debugger/framestack/framestackmodel.h <span style="color: grey">(fa1cbab)</span></li>
<li>debugger/framestack/framestackwidget.h <span style="color: grey">(9ee5a83)</span></li>
<li>debugger/interfaces/ibreakpointcontroller.h <span style="color: grey">(c39f497)</span></li>
<li>debugger/interfaces/iframestackmodel.h <span style="color: grey">(01b2545)</span></li>
<li>debugger/interfaces/ivariablecontroller.h <span style="color: grey">(d501a04)</span></li>
<li>debugger/util/pathmappings.h <span style="color: grey">(ffe58f2)</span></li>
<li>debugger/util/treemodel.h <span style="color: grey">(71704c0)</span></li>
<li>debugger/variable/variablecollection.h <span style="color: grey">(af732c3)</span></li>
<li>debugger/variable/variablewidget.h <span style="color: grey">(6a47497)</span></li>
<li>documentation/documentationview.h <span style="color: grey">(6c8cd50)</span></li>
<li>interfaces/context.h <span style="color: grey">(92f0448)</span></li>
<li>interfaces/iassistant.h <span style="color: grey">(61b6046)</span></li>
<li>interfaces/idebugcontroller.h <span style="color: grey">(72e52a4)</span></li>
<li>interfaces/idocumentcontroller.h <span style="color: grey">(3036cae)</span></li>
<li>interfaces/ilanguagecontroller.h <span style="color: grey">(04eb259)</span></li>
<li>interfaces/ipartcontroller.h <span style="color: grey">(4fed10e)</span></li>
<li>interfaces/iplugincontroller.h <span style="color: grey">(b77a8aa)</span></li>
<li>interfaces/iproject.h <span style="color: grey">(f0f38d6)</span></li>
<li>interfaces/iprojectcontroller.h <span style="color: grey">(86c2dfd)</span></li>
<li>interfaces/iprojectprovider.h <span style="color: grey">(1e76dbd)</span></li>
<li>interfaces/iruncontroller.h <span style="color: grey">(e342f6c)</span></li>
<li>interfaces/iselectioncontroller.h <span style="color: grey">(fb65377)</span></li>
<li>interfaces/isession.h <span style="color: grey">(1c1ee0a)</span></li>
<li>interfaces/isourceformatter.h <span style="color: grey">(f35748f)</span></li>
<li>interfaces/isourceformattercontroller.h <span style="color: grey">(efe03c1)</span></li>
<li>interfaces/launchconfigurationpage.h <span style="color: grey">(2589325)</span></li>
<li>language/assistant/renameassistant.h <span style="color: grey">(cfd3d67)</span></li>
<li>language/assistant/staticassistant.h <span style="color: grey">(4ca18c3)</span></li>
<li>language/assistant/staticassistantsmanager.h <span style="color: grey">(ab5430e)</span></li>
<li>language/backgroundparser/backgroundparser.h <span style="color: grey">(4a79651)</span></li>
<li>language/backgroundparser/documentchangetracker.h <span style="color: grey">(bacd0b5)</span></li>
<li>language/backgroundparser/parseprojectjob.h <span style="color: grey">(82e8b02)</span></li>
<li>language/backgroundparser/urlparselock.h <span style="color: grey">(6005f9f)</span></li>
<li>language/codecompletion/codecompletionmodel.h <span style="color: grey">(b22cd97)</span></li>
<li>language/codecompletion/codecompletionworker.h <span style="color: grey">(e2fb39b)</span></li>
<li>language/codecompletion/normaldeclarationcompletionitem.h <span style="color: grey">(c19f4b2)</span></li>
<li>language/codegen/applychangeswidget.h <span style="color: grey">(12fe48d)</span></li>
<li>language/codegen/archivetemplateloader.h <span style="color: grey">(886c7ec)</span></li>
<li>language/codegen/astchangeset.h <span style="color: grey">(000e5ae)</span></li>
<li>language/codegen/basicrefactoring.h <span style="color: grey">(72ae54a)</span></li>
<li>language/codegen/duchainchangeset.h <span style="color: grey">(0465da3)</span></li>
<li>language/codegen/sourcefiletemplate.h <span style="color: grey">(4810443)</span></li>
<li>language/codegen/utilities.h <span style="color: grey">(d8e00e6)</span></li>
<li>language/duchain/aliasdeclaration.h <span style="color: grey">(251c2e5)</span></li>
<li>language/duchain/builders/dynamiclanguageexpressionvisitor.h <span style="color: grey">(f06607a)</span></li>
<li>language/duchain/classdeclaration.h <span style="color: grey">(128cf05)</span></li>
<li>language/duchain/classfunctiondeclaration.h <span style="color: grey">(fe32111)</span></li>
<li>language/duchain/classmemberdeclaration.h <span style="color: grey">(a9c9487)</span></li>
<li>language/duchain/declaration.h <span style="color: grey">(c5f2450)</span></li>
<li>language/duchain/declarationid.h <span style="color: grey">(dd3c050)</span></li>
<li>language/duchain/duchainbase.h <span style="color: grey">(3c33e71)</span></li>
<li>language/duchain/duchaindumper.h <span style="color: grey">(87e91b0)</span></li>
<li>language/duchain/duchainlock.h <span style="color: grey">(0a16df1)</span></li>
<li>language/duchain/duchainpointer.h <span style="color: grey">(3fd906f)</span></li>
<li>language/duchain/ducontextdynamicdata.h <span style="color: grey">(c0a8472)</span></li>
<li>language/duchain/forwarddeclaration.h <span style="color: grey">(3deae92)</span></li>
<li>language/duchain/functiondeclaration.h <span style="color: grey">(e206c54)</span></li>
<li>language/duchain/functiondefinition.h <span style="color: grey">(237bddb)</span></li>
<li>language/duchain/identifier.h <span style="color: grey">(37fef57)</span></li>
<li>language/duchain/localindexedducontext.h <span style="color: grey">(a8eae2a)</span></li>
<li>language/duchain/namespacealiasdeclaration.h <span style="color: grey">(817631a)</span></li>
<li>language/duchain/navigation/abstractnavigationcontext.h <span style="color: grey">(29d5784)</span></li>
<li>language/duchain/navigation/problemnavigationcontext.h <span style="color: grey">(f19aa18)</span></li>
<li>language/duchain/navigation/usescollector.h <span style="color: grey">(b18f769)</span></li>
<li>language/duchain/navigation/usesnavigationcontext.h <span style="color: grey">(61ff1fe)</span></li>
<li>language/duchain/navigation/useswidget.h <span style="color: grey">(94087d7)</span></li>
<li>language/duchain/parsingenvironment.h <span style="color: grey">(f5524ce)</span></li>
<li>language/duchain/problem.h <span style="color: grey">(b8454fb)</span></li>
<li>language/duchain/tests/test_identifier.cpp <span style="color: grey">(1799946)</span></li>
<li>language/duchain/topducontextdata.h <span style="color: grey">(b9de0df)</span></li>
<li>language/duchain/topducontextdynamicdata.h <span style="color: grey">(1bdc465)</span></li>
<li>language/duchain/types/abstracttype.h <span style="color: grey">(7613168)</span></li>
<li>language/duchain/types/arraytype.h <span style="color: grey">(7a50ec6)</span></li>
<li>language/duchain/types/constantintegraltype.h <span style="color: grey">(445af1f)</span></li>
<li>language/duchain/types/containertypes.h <span style="color: grey">(b69e335)</span></li>
<li>language/duchain/types/delayedtype.h <span style="color: grey">(3954009)</span></li>
<li>language/duchain/types/enumerationtype.h <span style="color: grey">(61b8cfa)</span></li>
<li>language/duchain/types/enumeratortype.h <span style="color: grey">(3ba420f)</span></li>
<li>language/duchain/types/functiontype.h <span style="color: grey">(f1b15ea)</span></li>
<li>language/duchain/types/integraltype.h <span style="color: grey">(a93820e)</span></li>
<li>language/duchain/types/pointertype.h <span style="color: grey">(4f336cb)</span></li>
<li>language/duchain/types/referencetype.h <span style="color: grey">(38c91ad)</span></li>
<li>language/duchain/types/structuretype.h <span style="color: grey">(ccc533f)</span></li>
<li>language/duchain/types/typealiastype.h <span style="color: grey">(7eed573)</span></li>
<li>language/duchain/types/unsuretype.h <span style="color: grey">(5d504b4)</span></li>
<li>language/duchain/use.h <span style="color: grey">(5eff1f4)</span></li>
<li>language/editor/modificationrevision.h <span style="color: grey">(1fdff87)</span></li>
<li>language/editor/modificationrevisionset.h <span style="color: grey">(4093780)</span></li>
<li>language/highlighting/codehighlighting.h <span style="color: grey">(76f7f01)</span></li>
<li>language/highlighting/configurablecolors.h <span style="color: grey">(4a65172)</span></li>
<li>language/interfaces/codecontext.h <span style="color: grey">(72b5a4a)</span></li>
<li>language/util/basicsetrepository.h <span style="color: grey">(19faedb)</span></li>
<li>language/util/kdevhash.h <span style="color: grey">(4ac8c0d)</span></li>
<li>outputview/outputdelegate.h <span style="color: grey">(adbc275)</span></li>
<li>outputview/outputmodel.h <span style="color: grey">(8ec09e7)</span></li>
<li>plugins/appwizard/appwizardpagewidget.h <span style="color: grey">(1d6e105)</span></li>
<li>plugins/appwizard/appwizardplugin.h <span style="color: grey">(a59c187)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.h <span style="color: grey">(e9837fc)</span></li>
<li>plugins/appwizard/projectvcspage.h <span style="color: grey">(f587c86)</span></li>
<li>plugins/classbrowser/allclassesfolder.h <span style="color: grey">(94b16da)</span></li>
<li>plugins/classbrowser/classbrowserplugin.h <span style="color: grey">(0bcb8ff)</span></li>
<li>plugins/classbrowser/classmodelnode.h <span style="color: grey">(b1e7308)</span></li>
<li>plugins/classbrowser/projectfolder.h <span style="color: grey">(b721ee1)</span></li>
<li>plugins/codeutils/codeutilsplugin.h <span style="color: grey">(ca12e2a)</span></li>
<li>plugins/contextbrowser/browsemanager.h <span style="color: grey">(51166cd)</span></li>
<li>plugins/contextbrowser/contextbrowser.h <span style="color: grey">(09066cd)</span></li>
<li>plugins/cvs/commitdialog.h <span style="color: grey">(cba07c0)</span></li>
<li>plugins/cvs/cvsannotatejob.h <span style="color: grey">(ed6a3d9)</span></li>
<li>plugins/cvs/cvsdiffjob.h <span style="color: grey">(7e9feae)</span></li>
<li>plugins/cvs/cvsjob.h <span style="color: grey">(474381e)</span></li>
<li>plugins/cvs/cvslogjob.h <span style="color: grey">(ad32982)</span></li>
<li>plugins/cvs/cvsproxy.h <span style="color: grey">(4cab04c)</span></li>
<li>plugins/cvs/cvsstatusjob.h <span style="color: grey">(4eafff5)</span></li>
<li>plugins/cvs/importmetadatawidget.h <span style="color: grey">(9c776f1)</span></li>
<li>plugins/documentswitcher/documentswitcherplugin.h <span style="color: grey">(e85a54d)</span></li>
<li>plugins/documentswitcher/documentswitchertreeview.h <span style="color: grey">(cba65c8)</span></li>
<li>plugins/documentview/kdevdocumentmodel.h <span style="color: grey">(d851f5a)</span></li>
<li>plugins/documentview/kdevdocumentselection.h <span style="color: grey">(832484c)</span></li>
<li>plugins/execute/executeplugin.h <span style="color: grey">(3e379b1)</span></li>
<li>plugins/execute/nativeappconfig.h <span style="color: grey">(4eacf1e)</span></li>
<li>plugins/execute/projecttargetscombobox.h <span style="color: grey">(b29a7df)</span></li>
<li>plugins/executescript/executescriptplugin.h <span style="color: grey">(f4b2e60)</span></li>
<li>plugins/executescript/scriptappconfig.h <span style="color: grey">(66dd716)</span></li>
<li>plugins/externalscript/editexternalscript.h <span style="color: grey">(2b26ca7)</span></li>
<li>plugins/externalscript/externalscriptplugin.h <span style="color: grey">(706c55b)</span></li>
<li>plugins/externalscript/externalscriptview.h <span style="color: grey">(f54f062)</span></li>
<li>plugins/filemanager/kdevfilemanagerplugin.h <span style="color: grey">(e543106)</span></li>
<li>plugins/filetemplates/classidentifierpage.h <span style="color: grey">(8ce3da8)</span></li>
<li>plugins/filetemplates/licensepage.h <span style="color: grey">(0134afb)</span></li>
<li>plugins/filetemplates/outputpage.h <span style="color: grey">(f01d392)</span></li>
<li>plugins/filetemplates/overridespage.h <span style="color: grey">(db4863a)</span></li>
<li>plugins/filetemplates/templateclassassistant.h <span style="color: grey">(76e60f1)</span></li>
<li>plugins/filetemplates/templatepreview.h <span style="color: grey">(0324fb5)</span></li>
<li>plugins/git/gitjob.h <span style="color: grey">(8d0a8f2)</span></li>
<li>plugins/git/gitplugin.h <span style="color: grey">(6bafc59)</span></li>
<li>plugins/grepview/grepjob.h <span style="color: grey">(cb4e81f)</span></li>
<li>plugins/grepview/grepoutputview.h <span style="color: grey">(95c83dc)</span></li>
<li>plugins/grepview/grepviewplugin.h <span style="color: grey">(68dfdb2)</span></li>
<li>plugins/outlineview/outlinenode.h <span style="color: grey">(0e8d3f5)</span></li>
<li>plugins/patchreview/patchreview.h <span style="color: grey">(d7127b0)</span></li>
<li>plugins/problemreporter/problemhighlighter.h <span style="color: grey">(8d566ab)</span></li>
<li>plugins/problemreporter/problemnavigationcontext.h <span style="color: grey">(e761d14)</span></li>
<li>plugins/problemreporter/problemreporterplugin.h <span style="color: grey">(1014429)</span></li>
<li>plugins/problemreporter/problemsview.h <span style="color: grey">(ced44f2)</span></li>
<li>plugins/projectmanagerview/projectbuildsetwidget.h <span style="color: grey">(e843d3f)</span></li>
<li>plugins/projectmanagerview/projectmanagerviewplugin.h <span style="color: grey">(b180d25)</span></li>
<li>plugins/projectmanagerview/projecttreeview.h <span style="color: grey">(6512157)</span></li>
<li>plugins/quickopen/duchainitemquickopen.h <span style="color: grey">(af28afe)</span></li>
<li>plugins/quickopen/expandingtree/expandingtree.h <span style="color: grey">(17daa39)</span></li>
<li>plugins/quickopen/expandingtree/expandingwidgetmodel.h <span style="color: grey">(6d9618e)</span></li>
<li>plugins/quickopen/projectfilequickopen.h <span style="color: grey">(06c483d)</span></li>
<li>plugins/quickopen/projectitemquickopen.h <span style="color: grey">(5651375)</span></li>
<li>plugins/quickopen/quickopenmodel.h <span style="color: grey">(32e3e98)</span></li>
<li>plugins/quickopen/quickopenplugin.h <span style="color: grey">(8449f07)</span></li>
<li>plugins/standardoutputview/toolviewdata.h <span style="color: grey">(a082f9a)</span></li>
<li>plugins/subversion/svnaddjob.h <span style="color: grey">(03a1902)</span></li>
<li>plugins/subversion/svnaddjob_p.h <span style="color: grey">(456ed96)</span></li>
<li>plugins/subversion/svnblamejob.h <span style="color: grey">(562e0e8)</span></li>
<li>plugins/subversion/svnblamejob_p.h <span style="color: grey">(ebb77ff)</span></li>
<li>plugins/subversion/svncatjob.h <span style="color: grey">(6fab39b)</span></li>
<li>plugins/subversion/svncatjob_p.h <span style="color: grey">(ee488fe)</span></li>
<li>plugins/subversion/svncheckoutjob.h <span style="color: grey">(a5b8f02)</span></li>
<li>plugins/subversion/svncheckoutjob_p.h <span style="color: grey">(836e641)</span></li>
<li>plugins/subversion/svncheckoutmetadatawidget.h <span style="color: grey">(aec9cef)</span></li>
<li>plugins/subversion/svnclient.h <span style="color: grey">(56fe837)</span></li>
<li>plugins/subversion/svncommitjob_p.h <span style="color: grey">(ae00109)</span></li>
<li>plugins/subversion/svncopyjob.h <span style="color: grey">(d146c77)</span></li>
<li>plugins/subversion/svncopyjob_p.h <span style="color: grey">(8dd1d2c)</span></li>
<li>plugins/subversion/svndiffjob.h <span style="color: grey">(2d9b099)</span></li>
<li>plugins/subversion/svndiffjob_p.h <span style="color: grey">(fed5385)</span></li>
<li>plugins/subversion/svnimportjob.h <span style="color: grey">(1b4efee)</span></li>
<li>plugins/subversion/svnimportmetadatawidget.h <span style="color: grey">(25d178b)</span></li>
<li>plugins/subversion/svninfojob.h <span style="color: grey">(436bc3f)</span></li>
<li>plugins/subversion/svninfojob_p.h <span style="color: grey">(cb61e75)</span></li>
<li>plugins/subversion/svninternaljobbase.h <span style="color: grey">(4f2940e)</span></li>
<li>plugins/subversion/svnjobbase.h <span style="color: grey">(5f622cf)</span></li>
<li>plugins/subversion/svnlocationwidget.h <span style="color: grey">(9c927ce)</span></li>
<li>plugins/subversion/svnlogjob.h <span style="color: grey">(dbd7c07)</span></li>
<li>plugins/subversion/svnlogjob_p.h <span style="color: grey">(c198c43)</span></li>
<li>plugins/subversion/svnmovejob.h <span style="color: grey">(b52c1ad)</span></li>
<li>plugins/subversion/svnmovejob_p.h <span style="color: grey">(9055033)</span></li>
<li>plugins/subversion/svnremovejob.h <span style="color: grey">(d5dbc3d)</span></li>
<li>plugins/subversion/svnremovejob_p.h <span style="color: grey">(b0e8c41)</span></li>
<li>plugins/subversion/svnrevertjob.h <span style="color: grey">(0c9d585)</span></li>
<li>plugins/subversion/svnrevertjob_p.h <span style="color: grey">(a385aa6)</span></li>
<li>plugins/subversion/svnssldialog.h <span style="color: grey">(6ccc9b8)</span></li>
<li>plugins/subversion/svnstatusjob_p.h <span style="color: grey">(2477ed1)</span></li>
<li>plugins/subversion/svnupdatejob.h <span style="color: grey">(5e00b77)</span></li>
<li>plugins/subversion/svnupdatejob_p.h <span style="color: grey">(31fcece)</span></li>
<li>plugins/switchtobuddy/switchtobuddyplugin.h <span style="color: grey">(a7b566c)</span></li>
<li>plugins/testview/testviewplugin.h <span style="color: grey">(0fe8df1)</span></li>
<li>plugins/welcomepage/declarative/icoreobject.h <span style="color: grey">(1244b56)</span></li>
<li>plugins/welcomepage/uihelper.h <span style="color: grey">(78b1df6)</span></li>
<li>plugins/welcomepage/welcomepageview.h <span style="color: grey">(1aee0e7)</span></li>
<li>project/projectbuildsetmodel.h <span style="color: grey">(920ac1d)</span></li>
<li>project/projectchangesmodel.h <span style="color: grey">(7fd84c9)</span></li>
<li>project/projectconfigskeleton.h <span style="color: grey">(80e118b)</span></li>
<li>project/projectitemlineedit.h <span style="color: grey">(cda1807)</span></li>
<li>project/projectmodel.h <span style="color: grey">(22ac4fa)</span></li>
<li>project/projectproxymodel.h <span style="color: grey">(6feba14)</span></li>
<li>project/projectutils.h <span style="color: grey">(03fce30)</span></li>
<li>serialization/indexedstring.h <span style="color: grey">(7e06cab)</span></li>
<li>serialization/itemrepositoryregistry.h <span style="color: grey">(7185555)</span></li>
<li>serialization/tests/test_indexedstring.cpp <span style="color: grey">(f0c7958)</span></li>
<li>shell/core_p.h <span style="color: grey">(3caed06)</span></li>
<li>shell/debugcontroller.h <span style="color: grey">(a609e33)</span></li>
<li>shell/documentationcontroller.h <span style="color: grey">(0be4b2e)</span></li>
<li>shell/documentcontroller.h <span style="color: grey">(4c74860)</span></li>
<li>shell/editorconfigpage.h <span style="color: grey">(593523b)</span></li>
<li>shell/filteredproblemstore.h <span style="color: grey">(25c29d3)</span></li>
<li>shell/languagecontroller.h <span style="color: grey">(28d1e7e)</span></li>
<li>shell/launchconfiguration.h <span style="color: grey">(692bf5c)</span></li>
<li>shell/launchconfigurationdialog.h <span style="color: grey">(799c844)</span></li>
<li>shell/loadedpluginsdialog.h <span style="color: grey">(699475a)</span></li>
<li>shell/mainwindow_p.h <span style="color: grey">(fd23597)</span></li>
<li>shell/openprojectpage.h <span style="color: grey">(5602b74)</span></li>
<li>shell/plugincontroller.h <span style="color: grey">(d4f48a6)</span></li>
<li>shell/problemmodel.h <span style="color: grey">(48b7f1f)</span></li>
<li>shell/problemmodelset.h <span style="color: grey">(5aa2836)</span></li>
<li>shell/problemstore.h <span style="color: grey">(c1426c0)</span></li>
<li>shell/problemstorenode.h <span style="color: grey">(05844c2)</span></li>
<li>shell/project.h <span style="color: grey">(49d69a4)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(30db285)</span></li>
<li>shell/projectinfopage.h <span style="color: grey">(c58004b)</span></li>
<li>shell/projectsourcepage.h <span style="color: grey">(80c2cfb)</span></li>
<li>shell/runcontroller.h <span style="color: grey">(9e5ee2a)</span></li>
<li>shell/selectioncontroller.h <span style="color: grey">(ad77f85)</span></li>
<li>shell/session.h <span style="color: grey">(2b5a09f)</span></li>
<li>shell/sessioncontroller.h <span style="color: grey">(db5c7d0)</span></li>
<li>shell/sessiondialog.h <span style="color: grey">(8e97dfb)</span></li>
<li>shell/settings/sessionconfigskeleton.h <span style="color: grey">(8c76493)</span></li>
<li>shell/sourceformattercontroller.h <span style="color: grey">(fcf181f)</span></li>
<li>shell/statusbar.h <span style="color: grey">(295cc92)</span></li>
<li>shell/textdocument.h <span style="color: grey">(64952e0)</span></li>
<li>shell/uicontroller.h <span style="color: grey">(677ff3f)</span></li>
<li>shell/workingsets/workingset.h <span style="color: grey">(dd301c2)</span></li>
<li>shell/workingsets/workingsetwidget.h <span style="color: grey">(fdc1db9)</span></li>
<li>sublime/aggregatemodel.h <span style="color: grey">(c9d0caf)</span></li>
<li>sublime/container.h <span style="color: grey">(fecd865)</span></li>
<li>sublime/controller.h <span style="color: grey">(61883d2)</span></li>
<li>sublime/holdupdates.h <span style="color: grey">(ca0ee37)</span></li>
<li>sublime/idealcontroller.h <span style="color: grey">(8541191)</span></li>
<li>sublime/ideallayout.h <span style="color: grey">(4baac33)</span></li>
<li>sublime/idealtoolbutton.h <span style="color: grey">(e8b2baf)</span></li>
<li>sublime/mainwindow_p.h <span style="color: grey">(4a18f4c)</span></li>
<li>util/duchainify/main.h <span style="color: grey">(c0304ef)</span></li>
<li>util/environmentgrouplist.h <span style="color: grey">(0412c5e)</span></li>
<li>util/executecompositejob.h <span style="color: grey">(26d5617)</span></li>
<li>util/focusedtreeview.h <span style="color: grey">(f3bf065)</span></li>
<li>util/foregroundlock.h <span style="color: grey">(3d994da)</span></li>
<li>util/objectlist.h <span style="color: grey">(c59b487)</span></li>
<li>util/processlinemaker.h <span style="color: grey">(6a53922)</span></li>
<li>vcs/dvcs/dvcsjob.h <span style="color: grey">(81c6f33)</span></li>
<li>vcs/dvcs/ui/dvcsimportmetadatawidget.h <span style="color: grey">(c037be2)</span></li>
<li>vcs/dvcs/ui/revhistory/commitView.h <span style="color: grey">(046cd5f)</span></li>
<li>vcs/interfaces/icontentawareversioncontrol.h <span style="color: grey">(2ef5882)</span></li>
<li>vcs/models/brancheslistmodel.h <span style="color: grey">(f96255d)</span></li>
<li>vcs/models/vcsfilechangesmodel.h <span style="color: grey">(e77aa1a)</span></li>
<li>vcs/models/vcsitemeventmodel.h <span style="color: grey">(61966e4)</span></li>
<li>vcs/vcsjob.h <span style="color: grey">(95af667)</span></li>
<li>vcs/vcslocation.h <span style="color: grey">(3a270e8)</span></li>
<li>vcs/widgets/standardvcslocationwidget.h <span style="color: grey">(b1efd40)</span></li>
<li>vcs/widgets/vcscommitdialog.h <span style="color: grey">(85f8d59)</span></li>
<li>vcs/widgets/vcsdiffpatchsources.h <span style="color: grey">(6ca06f8)</span></li>
<li>vcs/widgets/vcsdiffwidget.h <span style="color: grey">(088b073)</span></li>
<li>vcs/widgets/vcsimportmetadatawidget.h <span style="color: grey">(c088e39)</span></li>
<li>vcs/widgets/vcslocationwidget.h <span style="color: grey">(1d921a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124427/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>