<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124445/">https://git.reviewboard.kde.org/r/124445/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Laszlo Kis-Adam.</div>
<p style="color: grey;"><i>Updated July 24, 2015, 6:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make KFunk happy</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-valgrind
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Memcheck is one of the Valgrind tools supported by kdev-valgrind.
The issues found by that tool will now be shown in the problems toolview, in the "Valgrind" tab, instead of it's own widget.
Therefore I removed the custom model and widget as well.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See screenshot:
http://i.imgur.com/xxFBnmu.jpg</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The rest of the tools are not problem checkers and their output doesn't fit into the problems toolview, so the valgrind toolview, and the rest of the custom models and views will have to stay.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Builds</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Works as intended</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7aeace1)</span></li>
<li>job.cpp <span style="color: grey">(865483e)</span></li>
<li>marks.cpp <span style="color: grey">(43c039d)</span></li>
<li>models/memcheckfakemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>models/memcheckfakemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>models/memcheckitemsimpl.h <span style="color: grey">(9d3d76a)</span></li>
<li>models/memcheckitemsimpl.cpp <span style="color: grey">(adfc03e)</span></li>
<li>models/memcheckmodel.h <span style="color: grey">(f8b8716)</span></li>
<li>models/memcheckmodel.cpp <span style="color: grey">(f05e919)</span></li>
<li>parsers/memcheckparser.h <span style="color: grey">(0673ca9)</span></li>
<li>parsers/memcheckparser.cpp <span style="color: grey">(4a85074)</span></li>
<li>plugin.h <span style="color: grey">(ebe3378)</span></li>
<li>plugin.cpp <span style="color: grey">(cbcbdea)</span></li>
<li>views/memcheckview.h <span style="color: grey">(1c399f3)</span></li>
<li>views/memcheckview.cpp <span style="color: grey">(f9201e3)</span></li>
<li>widget.cpp <span style="color: grey">(ef44a45)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124445/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>