<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124407/">https://git.reviewboard.kde.org/r/124407/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Boris Egorov.</div>
<p style="color: grey;"><i>Updated July 21, 2015, 2:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 827b94935714ccdd525a6d662826d27fe8b71ea9 by Boris Egorov to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix krazy2 warnings about foreach usage. Mostly about const ref
iterators usage; another issues (values for keys iteration) are not so
easy to solve.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://ebn.kde.org/krazy/reports/extragear/kdevelop/kdevplatform/index.html</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build and run tests (all passing).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/framestack/framestackwidget.cpp <span style="color: grey">(8052ecf)</span></li>
<li>language/assistant/staticassistantsmanager.cpp <span style="color: grey">(8c25c88)</span></li>
<li>language/backgroundparser/backgroundparser.cpp <span style="color: grey">(b109174)</span></li>
<li>language/backgroundparser/documentchangetracker.cpp <span style="color: grey">(b396750)</span></li>
<li>language/codecompletion/codecompletion.cpp <span style="color: grey">(815dcd5)</span></li>
<li>language/codecompletion/codecompletionitem.cpp <span style="color: grey">(b581d76)</span></li>
<li>language/codegen/templatesmodel.cpp <span style="color: grey">(b0d24fe)</span></li>
<li>language/duchain/duchain.cpp <span style="color: grey">(fbee364)</span></li>
<li>language/duchain/duchainutils.cpp <span style="color: grey">(8a26194)</span></li>
<li>language/highlighting/colorcache.cpp <span style="color: grey">(53e4b73)</span></li>
<li>plugins/contextbrowser/browsemanager.cpp <span style="color: grey">(67028b7)</span></li>
<li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(8be67e9)</span></li>
<li>plugins/externalscript/externalscriptplugin.cpp <span style="color: grey">(635cb3f)</span></li>
<li>plugins/grepview/grepdialog.cpp <span style="color: grey">(c2244c0)</span></li>
<li>plugins/grepview/grepfindthread.cpp <span style="color: grey">(6cd456c)</span></li>
<li>plugins/grepview/tests/test_findreplace.cpp <span style="color: grey">(4485de5)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(a2ed4cf)</span></li>
<li>plugins/quickopen/projectfilequickopen.cpp <span style="color: grey">(b63b840)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(3561828)</span></li>
<li>plugins/testview/testview.cpp <span style="color: grey">(c9e1644)</span></li>
<li>project/projectutils.cpp <span style="color: grey">(381cf7d)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(c2d0247)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(fb52deb)</span></li>
<li>shell/settings/sourceformattersettings.cpp <span style="color: grey">(8f55474)</span></li>
<li>shell/tests/test_testcontroller.cpp <span style="color: grey">(b57afc1)</span></li>
<li>vcs/widgets/vcsdiffpatchsources.cpp <span style="color: grey">(d982fc9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124407/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>