<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124412/">https://git.reviewboard.kde.org/r/124412/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By Raymond Wooninck.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-php
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch makes kdev-php build again without kdelibs4support. It seems that the porting was already done, but some headers were not yet removed. Only porting required was in duchain/tests/duchain.cpp with regards to the KStandardDirs</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch applies correctly and package builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>completion/context.h <span style="color: grey">(eac2348)</span></li>
<li>completion/model.cpp <span style="color: grey">(5df3aaf)</span></li>
<li>duchain/navigation/declarationnavigationcontext.cpp <span style="color: grey">(79503fa)</span></li>
<li>duchain/tests/duchain.cpp <span style="color: grey">(4090b34)</span></li>
<li>kdevphpversion.h.cmake <span style="color: grey">(5412689)</span></li>
<li>phplanguagesupport.cpp <span style="color: grey">(7862916)</span></li>
<li>phpparsejob.h <span style="color: grey">(0db2279)</span></li>
<li>phpparsejob.cpp <span style="color: grey">(76504df)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124412/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>