<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124139/">https://git.reviewboard.kde.org/r/124139/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2015, 10:27 p.m. UTC, <b>Maciej Poleski</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I not fully understand what is happening there. But in case of Clang (as a tool, not necessary compiler) settings like command line arguments are crucial (these consists of language standard version, but also lot of other settings like defines and include paths). In general these options may arbitrary influence compilation process (from triggering compilation error up to change in behavior). For this purpose Clang introduced conception of CompilationDatabase - set of command line arguments for each translation unit. Compilation database is (very likely) already used in kdev-clang (and also independently used by me in refactorings code). In case of CMake projects it is basically compile_commands.json file (which Clang handles automaticaly), in case of others... WIP.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't want to disturb Your work. I just wanted to mention about topic. From user point of view it could be handy to have these settings handled automaticaly (and also provably correct).</p></pre>
</blockquote>
<p>On July 14th, 2015, 9:58 a.m. UTC, <b>Sergey Kalinichev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, I'm aware of it. See the discussion at https://git.reviewboard.kde.org/r/121777/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also what if you didn't configure/build a project (either forgot, didn't want to or simply couldn't do that), yet interested in the code? In that case no json file is generated.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And we do not use the CompilationDatabase in kdev-clang, nor do we have any intention in doing so.</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On July 12th, 2015, 10:36 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated July 12, 2015, 10:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds two pages: One for session settings (code-completion, assistants), another one for project settings (parser command-line arguments).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Known issue: now we can set language standard in two places: DaIM - for deducing standard macros/includes and here - for the internal parser.
To solve this problem we can copy/move compilers infrastructure to kdev-clang. Also we can expose the compiler provider interface through DaIM (which is a much better solution imo). Suggestions?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(218cdcd)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(127e0a9)</span></li>
<li>clangsettings/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/clangsettingsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/clangsettingsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfig.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfig.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfigskeleton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsupport.h <span style="color: grey">(8ed1ec9)</span></li>
<li>clangsupport.cpp <span style="color: grey">(e22c554)</span></li>
<li>codecompletion/context.cpp <span style="color: grey">(f26921f)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(e07ef70)</span></li>
<li>duchain/clangparsingenvironment.h <span style="color: grey">(2e4ea8b)</span></li>
<li>duchain/clangparsingenvironment.cpp <span style="color: grey">(20a2dbf)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(74999de)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(cfafa33)</span></li>
<li>duchain/unknowndeclarationproblem.cpp <span style="color: grey">(908a518)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124139/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/f4bb2220-dc63-478d-b423-f31434496afb__project_settings.png">project settings.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/e1f59a46-f0b4-46fa-9f19-ffca4b887cf5__session_settings.png">session settings.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>