<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124139/">https://git.reviewboard.kde.org/r/124139/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd also prefer we make more stuff of the IaDM public and use it here.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124139/diff/3/?file=384465#file384465line253" style="color: black; font-weight: bold; text-decoration: underline;">clangsupport.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">253</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">number</span> <span class="o">?</span> <span class="k">nullptr</span> <span class="o">:</span> <span class="k">new</span> <span class="n">SessionSettings</span><span class="p">(</span><span class="n">parent</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for clarity, I'd rewrite this to</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">return number == 0 ? new SessionSettings(parent) : nullptr;
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or even</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">if (number == 0) {
return SessionSettings(parent);
} else {
return nullptr;
}
</pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On July 12th, 2015, 10:36 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated July 12, 2015, 10:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds two pages: One for session settings (code-completion, assistants), another one for project settings (parser command-line arguments).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Known issue: now we can set language standard in two places: DaIM - for deducing standard macros/includes and here - for the internal parser.
To solve this problem we can copy/move compilers infrastructure to kdev-clang. Also we can expose the compiler provider interface through DaIM (which is a much better solution imo). Suggestions?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(218cdcd)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(127e0a9)</span></li>
<li>clangsettings/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/clangsettingsmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/clangsettingsmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfig.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfig.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionconfigskeleton.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsettings/sessionsettings/sessionsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>clangsupport.h <span style="color: grey">(8ed1ec9)</span></li>
<li>clangsupport.cpp <span style="color: grey">(e22c554)</span></li>
<li>codecompletion/context.cpp <span style="color: grey">(f26921f)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(e07ef70)</span></li>
<li>duchain/clangparsingenvironment.h <span style="color: grey">(2e4ea8b)</span></li>
<li>duchain/clangparsingenvironment.cpp <span style="color: grey">(20a2dbf)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(74999de)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(cfafa33)</span></li>
<li>duchain/unknowndeclarationproblem.cpp <span style="color: grey">(908a518)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124139/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/f4bb2220-dc63-478d-b423-f31434496afb__project_settings.png">project settings.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/21/e1f59a46-f0b4-46fa-9f19-ffca4b887cf5__session_settings.png">session settings.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>