<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124258/">https://git.reviewboard.kde.org/r/124258/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124258/diff/2/?file=384413#file384413line73" style="color: black; font-weight: bold; text-decoration: underline;">interfaces/configpage.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="n">ConfigPageType</span> <span class="n">configPageType</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What happens when a LanguageConfigPage has childPages itself? That is not supported now, is it? And thereby, it shows that this API design does not work so nicely, no?</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On July 12th, 2015, 10:20 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated July 12, 2015, 10:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now a config page that contains language specific settings can be appended as a child page to the "Language support" config page.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is useful for e.g. kdev-clang plugin. See also https://git.reviewboard.kde.org/r/124139/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/configpage.h <span style="color: grey">(aed5dd6)</span></li>
<li>interfaces/configpage.cpp <span style="color: grey">(939c9d9)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(cffa161)</span></li>
<li>shell/configdialog.h <span style="color: grey">(2bf7f77)</span></li>
<li>shell/configdialog.cpp <span style="color: grey">(1e2eaab)</span></li>
<li>shell/languagecontroller.cpp <span style="color: grey">(d15a14b)</span></li>
<li>shell/settings/ccconfig.kcfg <span style="color: grey">()</span></li>
<li>shell/settings/ccconfig.kcfgc <span style="color: grey">(8fd94ca)</span></li>
<li>shell/settings/ccpreferences.h <span style="color: grey">(a736c36)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(9346e23)</span></li>
<li>shell/settings/ccpreferences.ui <span style="color: grey">(48bd90f)</span></li>
<li>shell/settings/languageconfig.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(6a662ce)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124258/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/05/ab17b5f1-b8c2-4383-8b0e-799f44dde14b__LanguageSupport.png">LanguageSupport.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>