<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123900/">https://git.reviewboard.kde.org/r/123900/</a>
</td>
</tr>
</table>
<br />
<p>On June 5th, 2015, 12:58 p.m. UTC, <b>Andreas Roth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Milian: Can you please commit this for me since i don't have write permission to the repo. Thx.</p></pre>
</blockquote>
<p>On June 5th, 2015, 4:05 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I could, but I'd rather have the individual commits merged - up to which commit should I merge from https://github.com/aroth-arsoft/kdevelop/tree/master-gdb-enhancements ?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, could you please run the unit tests - do they work for you? For me, the GDB test even crashes nowadays and is really unstable. It would be really nice if you could somehow first make sure the unit tests work and/or we get expected failures before merging new refactorings.</p></pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I updated my branch at github https://github.com/aroth-arsoft/kdevelop/commits/master-gdb-enhancements to only contain all relevant changes for this change request.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The unit tests now run without any failure on my machine.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On June 7th, 2015, 1:26 p.m. UTC, Andreas Roth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andreas Roth.</div>
<p style="color: grey;"><i>Updated June 7, 2015, 1:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Basically this contains the same changes as https://git.reviewboard.kde.org/r/121456/ but for the master branch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Repo is available at https://github.com/aroth-arsoft/kdevelop/tree/master-gdb-enhancements
- switch the assembler flavor from AT&T to Intel and back in the dissassembler widget
- remove StackList commands from the queue when a new Exec command arrives. This reduces the wait time when stepping through the code quickly.
- remove duplicated command in the queue. Mostly to eliminate duplicate variable updates.
- show the pending command in the command queue. This is purely for debugging and to check which commands are currently pending.
- slight improvements to memory view to use sizeof() when no size argument is given
-</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">run gdb unit tests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/debugsession.cpp <span style="color: grey">(fe015ae915f190cef266f1c52d0cedf16dfb9007)</span></li>
<li>debuggers/gdb/disassemblewidget.h <span style="color: grey">(c49e5bc1d9a9234888006e91127a880ef257ba23)</span></li>
<li>debuggers/gdb/disassemblewidget.cpp <span style="color: grey">(d1735e0ced0523519d2f3864c018bf1d6cfe8f7f)</span></li>
<li>debuggers/gdb/gdb.cpp <span style="color: grey">(66fee9e2f5f44a2f76564d9df5f701689a27a874)</span></li>
<li>debuggers/gdb/gdbcommand.h <span style="color: grey">(692c0ac6b6a98b71678f2aa89b8f7940ed390a2e)</span></li>
<li>debuggers/gdb/gdbcommand.cpp <span style="color: grey">(3207fdc896ec0dd0f7de319547bf4302042872a4)</span></li>
<li>debuggers/gdb/gdbcommandqueue.h <span style="color: grey">(9525301bf0614d7613d58ae4dfdcc08da709f7b4)</span></li>
<li>debuggers/gdb/gdbcommandqueue.cpp <span style="color: grey">(4bf11d0bd68e1aa0ef1cf2a8008011cf0fb76a55)</span></li>
<li>debuggers/gdb/memviewdlg.cpp <span style="color: grey">(08034e6631fc8f103005471a08cf0df031ff85f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123900/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>