<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123878/">https://git.reviewboard.kde.org/r/123878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 5th, 2015, 6:18 p.m. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just tested it, some comments:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">you also want to change the ALT shortcut for the quickfixes i.e. assistants now, i.e. ALT + 0 etc. should now be something else I guess</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">should the setting be remembered across restarts?</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">should a dialog tell the user that he can press meta + c again to get out of the concentration mode (if he pressed it accidentally, similar to ctrl + m to (un)hide the menu)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">otherwise, I like it. </li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and it crashed after pressing meta+c: three times in a row - just tested it and could reproduce it:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Application: KDevelop (kdevelop), signal: Segmentation fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f0a40365800 (LWP 25046))]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 10 (Thread 0x7f0a1e4ea700 (LWP 25047)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a36385e8d in poll () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a2d8059f2 in ?? () from /usr/lib/libxcb.so.1</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a2d80756f in xcb_wait_for_event () from /usr/lib/libxcb.so.1</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a1f5cf089 in ?? () from /usr/lib/qt/plugins/platforms/libqxcb.so</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 9 (Thread 0x7f0a0dc49700 (LWP 25049)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a2eb43d18 in pthread_cond_timedwait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a36f86256 in QWaitCondition::wait(QMutex*, unsigned long) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a347f4545 in KDevelop::DUChainPrivate::CleanupThread::run (this=0x51dbb80) at /home/milian/projects/kf5/src/extragear/kdevelop/kdevplatform/language/duchain/duchain.cpp:277</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 8 (Thread 0x7f0a07b91700 (LWP 25050)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a36385e8d in poll () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a2bf75c7c in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a2bf75d8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a371bbcff in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a37161ffa in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a36f801a4 in QThread::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 7 (Thread 0x7f0a07390700 (LWP 25051)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a36387b03 in select () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a370f87e0 in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 6 (Thread 0x7f09f335f700 (LWP 25055)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a36385e8d in poll () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a2bf75c7c in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a2bf75d8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a371bbd1b in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a37161ffa in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a36f801a4 in QThread::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a3492f1f4 in KDevelop::CompletionWorkerThread::run (this=0x54e3970) at /home/milian/projects/kf5/src/extragear/kdevelop/kdevplatform/language/codecompletion/codecompletionmodel.cpp:83</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 5 (Thread 0x7f09eb494700 (LWP 25065)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a36385e8d in poll () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a2bf75c7c in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a2bf75d8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a371bbcff in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a37161ffa in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a36f801a4 in QThread::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a3492f1f4 in KDevelop::CompletionWorkerThread::run (this=0x5ee3ce0) at /home/milian/projects/kf5/src/extragear/kdevelop/kdevplatform/language/codecompletion/codecompletionmodel.cpp:83</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 4 (Thread 0x7f09eac93700 (LWP 25073)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a2eb4396f in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a36f8631b in QWaitCondition::wait(QMutex*, unsigned long) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a32d8c01f in ThreadWeaver::Weaver::blockThreadUntilJobsAreBeingAssigned_locked (this=0x4317ea0, th=0x8365340) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:594</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a32d8be8e in ThreadWeaver::Weaver::takeFirstAvailableJobOrSuspendOrWait (this=0x4317ea0, th=0x8365340, threadWasBusy=true, suspendIfInactive=false, justReturning=false) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:554</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a32d96184 in ThreadWeaver::WorkingHardState::applyForWork (this=0x4318250, th=0x8365340, wasBusy=true) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:66</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a32d963f5 in non-virtual thunk to ThreadWeaver::WorkingHardState::applyForWork(ThreadWeaver::Thread*, bool) () at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:61</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a32d8c192 in ThreadWeaver::Weaver::applyForWork (this=0x4317ea0, th=0x8365340, wasBusy=true) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:568</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a32d91665 in ThreadWeaver::Thread::run (this=0x8365340) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/thread.cpp:103</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 3 (Thread 0x7f09e0bce700 (LWP 25075)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a2eb4396f in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a36f8631b in QWaitCondition::wait(QMutex*, unsigned long) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a32d8c01f in ThreadWeaver::Weaver::blockThreadUntilJobsAreBeingAssigned_locked (this=0x4317ea0, th=0x7f09dc002d70) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:594</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a32d8be8e in ThreadWeaver::Weaver::takeFirstAvailableJobOrSuspendOrWait (this=0x4317ea0, th=0x7f09dc002d70, threadWasBusy=false, suspendIfInactive=false, justReturning=false) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:554</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a32d96184 in ThreadWeaver::WorkingHardState::applyForWork (this=0x4318250, th=0x7f09dc002d70, wasBusy=false) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:66</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f0a32d963f5 in non-virtual thunk to ThreadWeaver::WorkingHardState::applyForWork(ThreadWeaver::Thread*, bool) () at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:61</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a32d8c192 in ThreadWeaver::Weaver::applyForWork (this=0x4317ea0, th=0x7f09dc002d70, wasBusy=false) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:568</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a32d9633a in ThreadWeaver::WorkingHardState::applyForWork (this=0x4318250, th=0x7f09dc002d70, wasBusy=true) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:73</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a32d963f5 in non-virtual thunk to ThreadWeaver::WorkingHardState::applyForWork(ThreadWeaver::Thread*, bool) () at /home/milian/projects/kf5/src/frameworks/threadweaver/src/workinghardstate.cpp:61</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f0a32d8c192 in ThreadWeaver::Weaver::applyForWork (this=0x4317ea0, th=0x7f09dc002d70, wasBusy=true) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/weaver.cpp:568</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007f0a32d91665 in ThreadWeaver::Thread::run (this=0x7f09dc002d70) at /home/milian/projects/kf5/src/frameworks/threadweaver/src/thread.cpp:103</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">11 0x00007f0a36f8508e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">12 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">13 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 2 (Thread 0x7f0a06b8f700 (LWP 30399)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f0a2eb4396f in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f0a331394a4 in ?? () from /usr/lib/libQt5Script.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f0a331394e9 in ?? () from /usr/lib/libQt5Script.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f0a2eb3e354 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f0a3638ebfd in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 1 (Thread 0x7f0a40365800 (LWP 25046)):
[KCrash Handler]</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f0a37e464df in QLayout::addChildWidget(QWidget*) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f0a37e4661f in QLayout::addWidget(QWidget*) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f0a3f1fe1f6 in Sublime::MainWindowPrivate::restoreConcentrationMode (this=0x28d3890) at /home/milian/projects/kf5/src/extragear/kdevelop/kdevplatform/sublime/mainwindow_p.cpp:233</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f0a3f207ab3 in QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (Sublime::MainWindowPrivate::<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)()>::call(void (Sublime::MainWindowPrivate::</em>)(), Sublime::MainWindowPrivate<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, void</em><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">) (f=(void (Sublime::MainWindowPrivate::</em>)(Sublime::MainWindowPrivate * const)) 0x7f0a3f1fddc0 <Sublime::MainWindowPrivate::restoreConcentrationMode()>, o=0x28d3890, arg=0x7fff99dfc500) at /usr/include/qt/QtCore/qobjectdefs_impl.h:500</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007f0a3f207a20 in QtPrivate::FunctionPointer<void (Sublime::MainWindowPrivate::<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)()>::call<QtPrivate::List<>, void>(void (Sublime::MainWindowPrivate::</em>)(), Sublime::MainWindowPrivate<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, void</em><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">) (f=(void (Sublime::MainWindowPrivate::</em>)(Sublime::MainWindowPrivate * const)) 0x7f0a3f1fddc0 <Sublime::MainWindowPrivate::restoreConcentrationMode()>, o=0x28d3890, arg=0x7fff99dfc500) at /usr/include/qt/QtCore/qobjectdefs_impl.h:519</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">11 0x00007f0a3f207948 in QtPrivate::QSlotObject<void (Sublime::MainWindowPrivate::<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase</em>, QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, void</em><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, bool</em>) (which=1, this_=0x26f5af0, r=0x28d3890, a=0x7fff99dfc500, ret=0x0) at /usr/include/qt/QtCore/qobject_impl.h:143</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">12 0x00007f0a37194aa7 in QMetaObject::activate(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, int, int, void</em>*) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">13 0x00007f0a37e1cdc2 in QAction::toggled(bool) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">14 0x00007f0a37e1f0c4 in QAction::setChecked(bool) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">15 0x00007f0a37e1f1b7 in QAction::activate(QAction::ActionEvent) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">16 0x00007f0a37e1f7ff in QAction::event(QEvent*) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">17 0x00007f0a37e2662c in QApplicationPrivate::notify_helper(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">18 0x00007f0a37e2bd10 in QApplication::notify(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">19 0x00007f0a3716457b in QCoreApplication::notifyInternal(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">20 0x00007f0a376aca98 in QShortcutMap::dispatchEvent(QKeyEvent*) () from /usr/lib/libQt5Gui.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">21 0x00007f0a376acbd1 in QShortcutMap::tryShortcutEvent(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QKeyEvent</em>) () from /usr/lib/libQt5Gui.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">22 0x00007f0a37e2bc08 in QApplication::notify(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">23 0x00007f0a3716457b in QCoreApplication::notifyInternal(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">24 0x00007f0a376808f7 in QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent*) () from /usr/lib/libQt5Gui.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">25 0x00007f0a37685895 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /usr/lib/libQt5Gui.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">26 0x00007f0a3766c1e8 in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Gui.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">27 0x00007f0a1f5fb500 in ?? () from /usr/lib/qt/plugins/platforms/libqxcb.so</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">28 0x00007f0a2bf759fd in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">29 0x00007f0a2bf75ce0 in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">30 0x00007f0a2bf75d8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">31 0x00007f0a371bbcff in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">32 0x00007f0a37161ffa in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">33 0x00007f0a37169a4c in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">34 0x0000000000415a83 in main (argc=3, argv=0x7fff99dfe898) at /home/milian/projects/kf5/src/extragear/kdevelop/kdevelop/app/main.cpp:618</h1></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you also want to change the ALT shortcut for the quickfixes i.e. assistants now, i.e. ALT + 0 etc. should now be something else I guess</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">I can change it into META+*, I'll think about it</li>
</ul>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">should the setting be remembered across restarts?</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Probably not, at least not yet. In fact, currently it's also being disabled when the area changes.</li>
</ul>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">should a dialog tell the user that he can press meta + c again to get out of the concentration mode (if he pressed it accidentally, similar to ctrl + m to (un)hide the menu)</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">We have a toolbar button. It should be enough, especially I manage to sneak this in: https://codereview.qt-project.org/#/c/112660/ (needs work, I know, won't be in before Qt 5.6)</li>
</ul>
</li>
</ul></pre>
<br />
<p>- Aleix</p>
<br />
<p>On June 7th, 2015, 11:51 a.m. CEST, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and KDE Usability.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 7, 2015, 11:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the perceived problems in KDevelop that affect me the most is that we're visually heavy. And we are. This patch doesn't address this, but I believe it will start to give us some hints on where we want to go.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch, basically adds a new togglable state to the main window, which allows our user to reduce some of the noise in the UI, allowing him to concentrate on what he came to do. This has a big advantage: we get to assume that the user is familiar with the shortcuts.
What it does:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">It hides all the toolview handles (not the toolviews).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">It hides the menu bar. Since I realized I was using Alt+* to access some menus, it's showing the menu when Alt is pressed.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">It adds a toolbar that lets the user get out of the concentration mode, and also receives the menu widget (with the working sets and area button).</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Also since I realized I was using some other shortcuts, I took the liberty to adapt them, I think they're far easier to remember than the previous ones.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Replaces the container tab bar to work without it (it has a label instead, long story, I know).</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now it works reasonably well, you can see the screenshot if you want to get an idea without trying the patch. I'm still undecided about whether we want to hide them.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been using it for work during the last few days. It doesn't crash (more) and well, I don't miss most of the things, so it's probably safe to get this in as is.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/contextbrowser/browsemanager.cpp <span style="color: grey">(70a3125)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(a1acdf3)</span></li>
<li>sublime/mainwindow_p.h <span style="color: grey">(5477091)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(aa9e10e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123878/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/22/f4ee28f6-1e0c-41bc-8d7a-b216d23ca5f4__kdevelop-concentration.png">Small Window</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/22/62c102b1-dbc7-4bd3-9e96-7b866709ca3b__kdevelop-concentration-1.png">Concentration Mode</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>