<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124003/">https://git.reviewboard.kde.org/r/124003/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2015, 12:11 p.m. CEST, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks interesting!
Do you know what's exactly the part that is making your views struggle? Why isn't resizeColumnToContents needed anymore?</p></pre>
</blockquote>
<p>On June 4th, 2015, 12:38 p.m. CEST, <b>Oleksandr Senkovych</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The reason it's so laggy is exactly in calling resizeColumnToContents on every insert and it's geting worse with each new item. Specifically, there is a raising number of item delegate sizeHint method calls.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually I did just a little bit more tesing and it seemes that there is a difference - if line does not fit into the kdevelop window if you don't resize a column as visible on theese screenshot:
http://i.imgur.com/1Cgmdxn.png (to the left - with patch applied, to the right - without).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually maybe there is a way to still keep previous behaviour - call resizeColumnToContents once after the grep job is finished.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So the difference is the scrollbar, right?</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On June 4th, 2015, 11:56 a.m. CEST, Oleksandr Senkovych wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Kevin Funk.</div>
<div>By Oleksandr Senkovych.</div>
<p style="color: grey;"><i>Updated June 4, 2015, 11:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Grep output view is very laggy if there is a lot of items. For example on my machine adding just 300 items to this view takes about 10 seconds and whole KDevelop UI becomes unresponsive. After applying proposed changes there is no problem to add even 10 000 items - everything works without any lag.
Also, I didn't notice any regression in the UI: all rows in the view are displayed properly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/grepview/grepoutputview.h <span style="color: grey">(5191c58)</span></li>
<li>plugins/grepview/grepoutputview.cpp <span style="color: grey">(2fba779)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124003/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>