<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123809/">https://git.reviewboard.kde.org/r/123809/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 16th, 2015, 5:19 p.m. MSK, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think the set of colors chosen works very well. There are several that are hardly different enough to be differentiable for me, especially on a quick glance (foo6, foo3 in the second bunch, foo3 and foo5 in the third bunch look very much the same). And at least foo8 and foo10 seem to have the exact same color.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How did you choose the colors? I faintly recall from my university time that there are formulas and theories about how easy it is to differ between color shades. Maybe with a few less number of colors their individual difference can be increased so they don't look so much alike?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How did you choose the colors?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't mention, but the initial set of 50 colors was generated by using the CIEDE2000 formula. Then 15 colors were removed (black, white, gray, pink, some hues of green e.t.c). Also about 5-8 colors were made a bit brighter, that's how I got that list of colors.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe with a few less number of colors their individual difference can be increased so they don't look so much alike?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes it's possible to choose 10-12 truly distinguishable colors and use it, but then again only first 10-12 declarations will be highlighted which is rarely enough.
So I'm thinking maybe we should use 10-12 colors at first and only when they run out switch to the much bigger set of 20-30 colors (some of them'll look alike, but it shouldn't matter much and it's still much better then no highlighting at all). What do you think?</p></pre>
<br />
<p>- Sergey</p>
<br />
<p>On May 16th, 2015, 11:07 a.m. MSK, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated May 16, 2015, 11:07 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes 2 issues:
*Currently rainbow highlighting only works for the first 10 declarations in Function and Other contexts. All other declarations get highlighted with the default color.
*The current interpolation algorithm is very poor, it can generate only about 10 different colors, all other look alike.
So this patch adds ~35 distinguishable colors, which should be more than enough for most cases.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/highlighting/colorcache.cpp <span style="color: grey">(e2729f2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123809/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/2fb289f0-69d8-4817-bf0d-d1691c98d3c1__test_highl_b.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/7bcdb744-e47f-435b-a02e-d0ad35b4a59e__test_highl_a.png">After</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/16/b67be6b5-b4bf-4d74-8ed9-206e897daa14__test_highl_adark.png">After (dark)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>